kubeadm: fail explicitly when using (stable,latest) in airgapped env #43999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
approved
|
This change is |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krousey, mikedanese
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
do-not-merge
k8s-github-robot
removed
the
lgtm
mikedanese
added
release-note-none
|
@k8s-bot kubeadm test this |
|
Automatic merge from submit-queue |
|
Cool, thanks @mikedanese! |
k8s-github-robot
pushed a commit
that referenced
this pull request
Apr 5, 2017
…3999-#44101-release-1.6 Automatic merge from submit-queue Automated cherry pick of #43999 #44101 release 1.6 Automated cherry pick of #43999 #44101 release 1.6 ```release-note kubeadm: Remove hard-coded default version when fetching stable version from the web fails. Fixes [kubeadm 1.6.1 deploying 1.6.0 control plane](kubernetes/kubeadm#224). ```
|
Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
enisoc
added
the
release-note
enisoc
removed
the
release-note-none
mintzhao
pushed a commit
to mintzhao/kubernetes
that referenced
this pull request
Jun 1, 2017
…pick-of-#43999-kubernetes#44101-release-1.6 Automatic merge from submit-queue Automated cherry pick of kubernetes#43999 kubernetes#44101 release 1.6 Automated cherry pick of kubernetes#43999 kubernetes#44101 release 1.6 ```release-note kubeadm: Remove hard-coded default version when fetching stable version from the web fails. Fixes [kubeadm 1.6.1 deploying 1.6.0 control plane](kubernetes/kubeadm#224). ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unintuitive and unnecessary behavior
This makes kubernetes deploy the proper version of the control plane.