Show help message in kubectl.sh if no args. #4393
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erictune
force-pushed
the
no_port_conflict
branch
from
da55f0e to
cfe2d59
Compare
|
didn't need docs change. needed make clean before commit hook. |
|
assigned to @filbranden for advice on whether this is the best practice in bash. |
erictune
changed the title
|
Problem with Better is either one of (Note that |
|
Dupe of #4390? |
When no args are passed to a script, "$@" is unset, which causes a shell error in "nounset" mode. This change passes an empty string to kubectl in that case so it can print help.
erictune
force-pushed
the
no_port_conflict
branch
from
cfe2d59 to
9e015fd
Compare
|
PTAL |
|
yes dup. |
|
but this one is further along in review so drop that one. |
filbranden
added a commit
that referenced
this pull request
Feb 12, 2015
Show help message in kubectl.sh if no args.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no args are passed to a script, "$@" is unset,
which causes a shell error in "nounset" mode.
This change passes an empty string to kubectl in that case
so it can print help.
This also updates docs/kubectl.md because the hook told me to.