Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update walkthrough to support kubectl create #4374

Merged
merged 1 commit into from
Feb 12, 2015
Merged

Update walkthrough to support kubectl create #4374

merged 1 commit into from
Feb 12, 2015
+2 −0

Conversation

ghodss
Copy link
Contributor

@ghodss ghodss commented Feb 12, 2015

kubectl create (as opposed to kubecfg) requires kind in the pod to work, so I add it here.

@smarterclayton
Copy link
Contributor

LGTM

@smarterclayton smarterclayton added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2015
@smarterclayton
Copy link
Contributor

Makes me wonder why they didn't get caught by examples_test.go validation though.

saad-ali added a commit that referenced this pull request Feb 12, 2015
@saad-ali
Merge pull request #4374 from ghodss/update-walkthrough
8557cd6 
Update walkthrough to support kubectl create
@saad-ali saad-ali merged commit 8557cd6 into kubernetes:master Feb 12, 2015
@ghodss
Copy link
Contributor Author

ghodss commented Feb 12, 2015

https://github.com/GoogleCloudPlatform/kubernetes/blob/master/examples/examples_test.go#L119 and https://github.com/GoogleCloudPlatform/kubernetes/blob/master/examples/examples_test.go#L140 are where it's tested... if you only ask to decode into a specific type, does it still require a kind field in the JSON?

@ghodss ghodss deleted the update-walkthrough branch February 12, 2015 22:46
@smarterclayton
Copy link
Contributor

It's probably a decision that different code needs to make differently. The rest api should probably reject untyped incoming objects, but a cli or generation / import function may not.

On Feb 12, 2015, at 5:46 PM, Sam Ghods notifications@github.com wrote:

https://github.com/GoogleCloudPlatform/kubernetes/blob/master/examples/examples_test.go#L119 and https://github.com/GoogleCloudPlatform/kubernetes/blob/master/examples/examples_test.go#L140 are where it's tested... if you only ask to decode into a specific type, does it still require a kind field in the JSON?

—
Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghodss @smarterclayton @saad-ali