Improve error handling for '/containerLogs' API in kubelet. #4373
+80
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dchen1107: I see that many of the kubelet APIs can follow a input validation pattern similar to this PR. WDYT? |
|
LGTM, will merge tomorrow morning. |
saad-ali
added
the
lgtm
saad-ali
added a commit
that referenced
this pull request
Feb 12, 2015
Improve error handling for '/containerLogs' API in kubelet.
|
This broke how we fetch logs for containers that are stopped - I don't think our intent was to not return logs for stopped containers, just make it deterministic. |
| for cName, cStatus := range podStatus.Info { | ||
| if containerName == cName { | ||
| exists = true | ||
| if !cStatus.Ready { |
There was a problem hiding this comment.
Specifically, this check is too aggressive, it means you cannot return logs for a container that ran to completion and succeeded (a RestartPolicyNever)
This was referenced Feb 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3391