Add extra explanation of the purpose of service's ContainerPort field to the API comments. #4371
+14
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, waiting on @abonas to ACK |
the API comments. We were asked about this in issue kubernetes#4332.
|
Taking @abonas's ack on the issue as an ack on the change here, after adding additional clarification that the "container" being talked about is the container the service points to. |
a-robinson
added a commit
that referenced
this pull request
Feb 12, 2015
Add extra explanation of the purpose of service's ContainerPort field to the API comments.
|
Ah, I'm sorry, I assumed that's where most people looked for docs. I did add a bit more to the description strings, at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a pretty tiny change, but we were asked about this in issue #4332.
@abonas, does this extra explanation make it clearer at all? If not, do you have a recommendation of how to improve it?