Update a few regex patterns to support release candidates #43642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
enisoc
added
cherry-pick-approved
|
@eparis @mikedanese @roberthbailey can one of you approve this? I think 1.6 upgrade tests might start failing until this is merged (and cherrypicked). |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eparis, ixdy, liggitt
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
enisoc
added
kind/upgrade-test-failure
kind/failing-test
|
Automatic merge from submit-queue (batch tested with PRs 43642, 43170, 41813, 42170, 41581) |
|
@ixdy PR needs rebase |
k8s-github-robot
added
the
needs-rebase
|
Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
k8s-github-robot
pushed a commit
that referenced
this pull request
May 1, 2017
Automatic merge from submit-queue Support arbitrary alphanumeric strings as prerelease identifiers **What this PR does / why we need it**: this is basically an extension of #43642, but supports more general prerelease identifiers, per the spec at http://semver.org/#spec-item-9. These regular expressions are still a bit more restrictive than the SemVer spec allows (we disallow hyphens, and we require the format `-foo.N` instead of arbitrary `-foo.X.bar.Y.bazZ`), but this should support our needs without changing too much more logic or breaking other assumptions. **Release note**: ```release-note NONE ```
mintzhao
pushed a commit
to mintzhao/kubernetes
that referenced
this pull request
Jun 1, 2017
…-of-#43642-upstream-release-1.6 Automatic merge from submit-queue Automated cherry pick of kubernetes#43642 Cherry pick of kubernetes#43642 on release-1.6. kubernetes#43642: Update a few regex patterns to support release candidates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: A release candidate was cut for 1.6 (v1.6.0-rc.1), but some scripts don't recognize this version string.
Release note: