Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor clarification of --server flag. #4364

Merged
merged 1 commit into from
Feb 12, 2015
Merged

Minor clarification of --server flag. #4364

merged 1 commit into from
Feb 12, 2015
+24 −24

Conversation

vmarmol
Copy link
Contributor

@vmarmol vmarmol commented Feb 12, 2015

Fixes #3425.

roberthbailey
roberthbailey reviewed Feb 12, 2015
View reviewed changes
pkg/client/clientcmd/overrides.go
@@ -131,7 +131,7 @@ func BindAuthInfoFlags(authInfo *clientcmdapi.AuthInfo, flags *pflag.FlagSet, fl

// BindClusterFlags is a convenience method to bind the specified flags to their associated variables
func BindClusterFlags(clusterInfo *clientcmdapi.Cluster, flags *pflag.FlagSet, flagNames ClusterOverrideFlags) {
flags.StringVarP(&clusterInfo.Server, flagNames.APIServer, flagNames.APIServerShort, "", "The address of the Kubernetes API server")
flags.StringVarP(&clusterInfo.Server, flagNames.APIServer, flagNames.APIServerShort, "", "The address, and port, of the Kubernetes API server")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This sentence doesn't need commas.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, PTAL.

@vmarmol vmarmol force-pushed the cleanup branch 3 times, most recently from 36ed720 to 1fcfbc5 Compare February 12, 2015 00:28
@roberthbailey
Copy link
Contributor

LGTM.

@roberthbailey roberthbailey self-assigned this Feb 12, 2015
@vmarmol vmarmol force-pushed the cleanup branch 2 times, most recently from ebd1a98 to 0a64fec Compare February 12, 2015 01:10
@saad-ali saad-ali added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2015
saad-ali added a commit that referenced this pull request Feb 12, 2015
@saad-ali
Merge pull request #4364 from vmarmol/cleanup
b5f4849 
Minor clarification of --server flag.
@saad-ali saad-ali merged commit b5f4849 into kubernetes:master Feb 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@roberthbailey roberthbailey

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

default port to 8080 for kubectl command line parameter
3 participants
@vmarmol @roberthbailey @saad-ali