Stop putting env vars into BoundPods. #4359
Merged
+6
−461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 11, 2015
Closed
|
LGTM So nice. |
|
Do the Red Hat folks have concerns? |
|
None. |
|
not sure why integration test failed on go1.4 on travis. Works for me and shippable and travis+1.3 |
saad-ali
added
the
lgtm
|
@erictune Could you rebase please |
They will still show up in etcd. They never were available through the API. A subsequent PR(s) will rip out all BoundPods code. Working in small increments. This PR will cause users on lagging cloud providers to not get env vars in their pods if they update to this code. They have already been warned via email. Removed unit tests of BasicBoundPodFactory. There is adequate coverage in pkg/kubelet/kubelet_test.go.
erictune
force-pushed
the
no_bound_pod_envs
branch
from
1953014 to
5b45696
Compare
|
@saad-ali rebased |
saad-ali
added a commit
that referenced
this pull request
Feb 12, 2015
Stop putting env vars into BoundPods.
|
Does this close #4176? |
|
no On Thu, Feb 12, 2015 at 11:19 AM, Zach Loafman notifications@github.com
|
|
and by "no" I mean yes. On Thu, Feb 12, 2015 at 11:21 AM, Eric Tune etune@google.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They will still show up in etcd. They never were available
through the API.
A subsequent PR(s) will rip out all BoundPods code.
Working in small increments.
This PR will cause users on lagging cloud providers
to not get env vars in their pods if they update to this code.
They have already been warned via email.
Removed unit tests of BasicBoundPodFactory.
There is adequate coverage in pkg/kubelet/kubelet_test.go.