unit test for kubectl config set-cluster #43505

zjj2wry · 2017-03-22T07:38:09Z

What this PR does / why we need it:
unit test for create cluster

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
i want test secure mode,but CA path how set?

Release note:

NONE

k8s-reviewable · 2017-03-22T07:38:16Z

This change is

k8s-ci-robot · 2017-03-22T07:38:17Z

Hi @zjj2wry. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

zjj2wry · 2017-03-22T09:11:17Z

@adohe

adohe-zz · 2017-03-27T05:58:19Z

/assign @adohe

adohe-zz · 2017-03-27T05:59:08Z

@zjj2wry I would review this today, sorry about late response.

zjj2wry · 2017-03-30T02:12:14Z

@adohe ok,think you

adohe-zz · 2017-04-18T13:00:49Z

pkg/kubectl/cmd/config/create_cluster_test.go

+		},
+	}
+	test := createClusterTest{
+		description: "Testing kubectl config set-cluster a exist cluster",


confused description.

Make it "Testing 'kubectl config set-cluster' with an existing cluster"

adohe-zz · 2017-04-18T13:02:18Z

@zjj2wry I am sorry about the late, I was just too busy recently. This generally lgtm. Could you please rebase this? Then I will apply the label.

zjj2wry · 2017-05-17T10:16:58Z

@k8s-bot verify test this

zjj2wry · 2017-05-23T04:08:01Z

@thockin i rebase lastest master. but the do-not-merge tag always exists. how can i remove it ? think you very much.

zjj2wry · 2017-05-23T04:11:25Z

/unassign @dshulyak

thockin · 2017-05-23T04:51:33Z

I cleared do-not-merge, but someone has to LGTM who knows this code.

zjj2wry · 2017-05-23T06:27:10Z

@k8s-bot pull-kubernetes-unit test this

zjj2wry · 2017-05-24T04:26:52Z

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

zjj2wry · 2017-05-24T04:27:02Z

@k8s-bot verify test this

zjj2wry · 2017-05-27T15:34:25Z

@fabianofranz sorry about ping you often. can you help me review this.the assign reviewer maybe not online recent. think you ~

fabianofranz · 2017-05-30T20:49:05Z

pkg/kubectl/cmd/config/create_cluster_test.go

+func TestCreateCluster(t *testing.T) {
+	conf := clientcmdapi.Config{}
+	test := createClusterTest{
+		description: "Testing kubectl config set-cluster a cluster",


Make it "Testing 'kubectl config set-cluster' with a new cluster"

fabianofranz · 2017-05-30T20:51:30Z

pkg/kubectl/cmd/config/create_cluster_test.go

+	cmd.SetArgs(test.args)
+	cmd.Flags().Parse(test.flags)
+	if err := cmd.Execute(); err != nil {
+		t.Fatalf("unexpected error executing command: %v,kubectl set-cluster args:%v,flags:%v", err, test.args, test.flags)


t.Fatalf("unexpected error executing command: %v, args: %v, flags: %v", err, test.args, test.flags)

fabianofranz · 2017-05-30T20:51:46Z

pkg/kubectl/cmd/config/create_cluster_test.go

+	}
+	if len(test.expected) != 0 {
+		if buf.String() != test.expected {
+			t.Errorf("Failded in %q\n expected %v\n but got %v", test.description, test.expected, buf.String())


"Failed ..."

fabianofranz · 2017-05-30T20:53:09Z

pkg/kubectl/cmd/config/create_cluster_test.go

+	if len(test.args) > 0 {
+		cluster, ok := config.Clusters[test.args[0]]
+		if !ok {
+			t.Errorf("expected create cluster %v, but got nil", test.args[0])


t.Errorf("expected cluster %v, got nil", test.args[0])

fabianofranz · 2017-05-30T20:53:46Z

@zjj2wry just a few minor nits.

zjj2wry · 2017-05-31T06:20:07Z

@fabianofranz thank you for review :)

fabianofranz · 2017-05-31T20:52:51Z

@zjj2wry thank you!

/lgtm

k8s-github-robot · 2017-06-01T00:50:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adohe, fabianofranz, zjj2wry

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~pkg/kubectl/OWNERS~~ [adohe,fabianofranz]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-ci-robot · 2017-06-01T03:05:41Z

@zjj2wry: The following test(s) failed:

Test name	Commit	Details	Rerun command
Jenkins verification	`988aadb`	link	`@k8s-bot verify test this`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

zjj2wry · 2017-06-01T10:10:53Z

@k8s-bot pull-kubernetes-node-e2e test this
@k8s-bot pull-kubernetes-kubemark-e2e-gce test this
@k8s-bot pull-kubernetes-e2e-kops-aws test this
@k8s-bot pull-kubernetes-federation-e2e-gce test this
@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

k8s-github-robot · 2017-06-01T12:16:01Z

Automatic merge from submit-queue

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 22, 2017

k8s-github-robot assigned dshulyak Mar 22, 2017

k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Mar 22, 2017

zjj2wry changed the title ~~create cluster~~ unit test for create cluster Mar 22, 2017

zjj2wry changed the title ~~unit test for create cluster~~ unit test for kubectl config set-cluster Mar 22, 2017

zjj2wry force-pushed the 004 branch 2 times, most recently from 2427003 to e4e0636 Compare March 25, 2017 11:00

k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 25, 2017

zjj2wry force-pushed the 004 branch from e4e0636 to 47cd9cc Compare March 25, 2017 11:30

k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2017

k8s-ci-robot assigned adohe-zz Mar 27, 2017

grodrigues3 added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 5, 2017

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2017

adohe-zz reviewed Apr 18, 2017

View reviewed changes

zjj2wry force-pushed the 004 branch from 47cd9cc to 93cc2ac Compare April 19, 2017 02:04

k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 19, 2017

zjj2wry force-pushed the 004 branch from 93cc2ac to 988aadb Compare April 19, 2017 02:05

k8s-github-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 19, 2017

zjj2wry force-pushed the 004 branch from 988aadb to 11e1631 Compare May 23, 2017 03:59

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2017

thockin removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label May 23, 2017

zjj2wry force-pushed the 004 branch from 11e1631 to da09608 Compare May 23, 2017 06:18

zjj2wry force-pushed the 004 branch from da09608 to e1404a7 Compare May 24, 2017 02:15

zjj2wry force-pushed the 004 branch from e1404a7 to 8ba22b4 Compare May 24, 2017 05:19

fabianofranz reviewed May 30, 2017

View reviewed changes

unit test for create cluster

7c362f2

zjj2wry force-pushed the 004 branch from 8ba22b4 to 7c362f2 Compare May 31, 2017 06:19

k8s-ci-robot assigned fabianofranz May 31, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2017

k8s-github-robot merged commit 2269f5c into kubernetes:master Jun 1, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

unit test for kubectl config set-cluster #43505

unit test for kubectl config set-cluster #43505

zjj2wry commented Mar 22, 2017 •

edited

Loading

k8s-reviewable commented Mar 22, 2017

k8s-ci-robot commented Mar 22, 2017

zjj2wry commented Mar 22, 2017

adohe-zz commented Mar 27, 2017

adohe-zz commented Mar 27, 2017

zjj2wry commented Mar 30, 2017

adohe-zz Apr 18, 2017

fabianofranz May 30, 2017

adohe-zz commented Apr 18, 2017

zjj2wry commented May 17, 2017

zjj2wry commented May 23, 2017

zjj2wry commented May 23, 2017 •

edited

Loading

thockin commented May 23, 2017

zjj2wry commented May 23, 2017

zjj2wry commented May 24, 2017

zjj2wry commented May 24, 2017

zjj2wry commented May 27, 2017

fabianofranz May 30, 2017

fabianofranz May 30, 2017

fabianofranz May 30, 2017

fabianofranz May 30, 2017

fabianofranz commented May 30, 2017

zjj2wry commented May 31, 2017

fabianofranz commented May 31, 2017

k8s-github-robot commented Jun 1, 2017

k8s-ci-robot commented Jun 1, 2017 •

edited

Loading

zjj2wry commented Jun 1, 2017

k8s-github-robot commented Jun 1, 2017

unit test for kubectl config set-cluster #43505

unit test for kubectl config set-cluster #43505

Conversation

zjj2wry commented Mar 22, 2017 • edited Loading

k8s-reviewable commented Mar 22, 2017

k8s-ci-robot commented Mar 22, 2017

zjj2wry commented Mar 22, 2017

adohe-zz commented Mar 27, 2017

adohe-zz commented Mar 27, 2017

zjj2wry commented Mar 30, 2017

adohe-zz Apr 18, 2017

Choose a reason for hiding this comment

fabianofranz May 30, 2017

Choose a reason for hiding this comment

adohe-zz commented Apr 18, 2017

zjj2wry commented May 17, 2017

zjj2wry commented May 23, 2017

zjj2wry commented May 23, 2017 • edited Loading

thockin commented May 23, 2017

zjj2wry commented May 23, 2017

zjj2wry commented May 24, 2017

zjj2wry commented May 24, 2017

zjj2wry commented May 27, 2017

fabianofranz May 30, 2017

Choose a reason for hiding this comment

fabianofranz May 30, 2017

Choose a reason for hiding this comment

fabianofranz May 30, 2017

Choose a reason for hiding this comment

fabianofranz May 30, 2017

Choose a reason for hiding this comment

fabianofranz commented May 30, 2017

zjj2wry commented May 31, 2017

fabianofranz commented May 31, 2017

k8s-github-robot commented Jun 1, 2017

k8s-ci-robot commented Jun 1, 2017 • edited Loading

zjj2wry commented Jun 1, 2017

k8s-github-robot commented Jun 1, 2017

zjj2wry commented Mar 22, 2017 •

edited

Loading

zjj2wry commented May 23, 2017 •

edited

Loading

k8s-ci-robot commented Jun 1, 2017 •

edited

Loading