Initial implementation of kube-dump.sh #4346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigning to @filbranden since he's likely to have some bash-style comments. |
| ALL_NODES=(${MINION_NAMES[*]} ${MASTER_NAME}) | ||
| for NODE in ${ALL_NODES[*]}; do | ||
| echo "kube-dump.sh: Node $NODE:" | ||
| ssh-to-node $NODE ' |
There was a problem hiding this comment.
Double quotes:
ssh-to-node "${node}" ' ...
|
A few comments, looks good otherwise. |
jszczepkowski
force-pushed
the
master
branch
from
631bacf to
6456575
Compare
|
Looks good. May I ask you to squash your commits into a single one before the merge? (You can do that with |
…Kubernetes cluster for debugging. Tested on GCE only. This is initial attempt to fix kubernetes#3500.
jszczepkowski
force-pushed
the
master
branch
from
6456575 to
f94da1e
Compare
|
Done. |
filbranden
added a commit
that referenced
this pull request
Feb 12, 2015
Initial implementation of kube-dump.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script which dumps state of Kubernetes cluster for debugging. Tested on GCE only. This is initial attempt to fix #3500.