Don't include port in config when not specified. #4345
Merged
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no port is specified the flag default of "-1" is taken. Fixes kubernetes#4305
|
Shippable is failing (although it has been flaky lately). However, when I click on the link I get the main page :( is there some foo I am missing to see the results? |
|
You have to sign up Shippable with your github account (grant it access to your email, etc). There should be a button (github?) on the Shippable main page that you opened. |
|
Thanks for the tip @yujuhong! Now I can see the results :) re-running tests. |
roberthbailey
added a commit
that referenced
this pull request
Feb 11, 2015
Don't include port in config when not specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no port is specified the flag default of "-1" is taken.
Fixes #4305