Make gce's kubeconfig context include the gce project #4337
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the .kubeconfig context that gce kube-up creates to project + instance prefix, so you can spin up clusters with the same name in different compute projects without overwriting .kubeconfig.
|
So we are using project+prefix as a substitute for letting someone assign a name to a cluster? |
|
Why not have a sub-directory for each project? Or is that too much hierarchy? |
|
@roberthbailey: yes, this is a temporary solution to fix the overwriting .kubeconfig problem. Proposal for a better solution in #4298 @satnam6502: that's a bit too much hierarchy, particularly because it would only apply to gce. With this change, your .kube directory after creating multiple clusters in different projects will look like this: Note that you can now have 2 gce clusters with the same name if they are in different projects. |
|
Ping @satnam6502 |
satnam6502
added
the
lgtm
satnam6502
added a commit
that referenced
this pull request
Feb 12, 2015
Make gce's kubeconfig context include the gce project
j3ffml
added a commit
to j3ffml/kubernetes
that referenced
this pull request
Feb 13, 2015
satnam6502
added a commit
that referenced
this pull request
Feb 13, 2015
Retry #4337: Make gce kubeconfig context include project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the .kubeconfig context that gce kube-up creates to project + instance prefix, so you can spin up clusters with the same name in different compute projects without overwriting .kubeconfig.