Bindings were not correctly removed across namespaces on pod update and delete #4329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd delete BoundPods must be checked for Name and Namespace equality, not just name equality. In the future, we should also check for UID equality.
smarterclayton
added
priority/critical-urgent
|
The fix LGTM but I'll defer to someone who knows more about this part of the code. |
|
@derekwaynecarr please review - I want to get this merged |
|
LGTM - that was a bad bug ;-) |
smarterclayton
added a commit
that referenced
this pull request
Feb 12, 2015
…oved Bindings were not correctly removed across namespaces on pod update and delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pods are deleted (or updated) and there is another pod bound to that host with the same pod name in a different namespace, the wrong binding can get removed. It's likely people out there using multiple namespaces today have corrupted bindings - we really need to be able to regenerate / check the bindings.