Allow AtomicUpdate() to surface the error when the key doesn't exist #4326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dchen1107, @davidopp |
|
Update: ran the script I used to reproduce the issue and found no phantom pods after creating/deleting >800 pods in total over a long period of time (with this PR). |
|
Add a test case that reproduces the failure |
In some cases, when the key doesn't exist, AtomicUpdate should simply fail and surface the error. This change adds a new function parameter "ignoreNotFound" for this purpose.
yujuhong
force-pushed
the
phantom_pods
branch
from
1dcd5ff to
6813683
Compare
|
@smarterclayton, I updated the PR to include the test. PTAL! |
|
LGTM |
smarterclayton
added
the
lgtm
smarterclayton
added a commit
that referenced
this pull request
Feb 12, 2015
Allow AtomicUpdate() to surface the error when the key doesn't exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, when the key doesn't exist, AtomicUpdate should simply fail and
surface the error. This PR adds a new function parameter "ignoreNotFound"
for this purpose.
This PR fixes the main symptom in #3950.