Modify nginx port to avoid collision with api server #4322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,7 +11,7 @@ | |||
| "image": "dockerfile/nginx", | |||
| "ports": [{ | |||
| "containerPort": 80, | |||
| "hostPort": 8080 | |||
| "hostPort": 8081 | |||
There was a problem hiding this comment.
Is it possible to do this without using a host port? Services have generally replaced the need for host ports, and using host ports mean that the scheduler can't put two instances of the same pod onto a single node.
|
Herp, I completely missed your question. Yep, I can add a services example in another PR. However I'd still like a simple pod.json, to use against both localhost and gce, and the services solution won't help with the former. |
|
@roberthbailey fyi, assigning to primary |
|
LGTM. |
yujuhong
added a commit
that referenced
this pull request
Feb 18, 2015
Modify nginx port to avoid collision with api server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spinning up a local cluster with the basic pod manifest in examples/pod.json causes a port collision, since the api server also runs on 8080. This PR changes the port to 8081, and updates the documentation appropriately.