Add ability to watch namespaces from client #4313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekwaynecarr
force-pushed
the
client_watch_namespaces
branch
from
a8d06e0 to
bf7952f
Compare
|
@dchen1107 can you take a look at this one? |
|
Add a client test please. |
|
@smarterclayton will add a test today that uses an EmptyWatch |
derekwaynecarr
force-pushed
the
client_watch_namespaces
branch
from
bf7952f to
73aa0cc
Compare
|
@smarterclayton - added a test case to validate watch constructs what we expect. |
|
LGTM |
smarterclayton
added
the
lgtm
smarterclayton
added a commit
that referenced
this pull request
Feb 12, 2015
Add ability to watch namespaces from client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add client methods to support watch of namespaces.