Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release 1.5] Update cadvisor godeps to v0.25.0 #43113

Merged
merged 1 commit into from
Mar 22, 2017
Merged

[Release 1.5] Update cadvisor godeps to v0.25.0 #43113

merged 1 commit into from
Mar 22, 2017

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Mar 15, 2017 •
edited
Loading

This PR updates the cAdvisor Godeps for the 1.5 branch. This includes a number of critical bugfixes including:
cadvisor#1558, cadvisor#1573

This is a large change on account of the aws dependency update. However, many affected users have requested that this be cherrypicked into 1.5 and 1.4 (coming soon)

- Disable thin_ls due to excessive iops
- Ignore .mount cgroups, fixing dissappearing stats
- Fix wc goroutine leak
- Update aws-sdk-go dependency to 1.6.10

cc @calebamiles remember this? @jessfraz @timstclair

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 15, 2017
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 15, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@dashpole
Copy link
Contributor Author

Forgot to mention: this is effectively a combination of cherrypicking #40095, and #42899. However, it was simpler to just perform one godep update.

@dashpole dashpole changed the title Update cadvisor godeps to v0.25.0 [Release 1.5] Update cadvisor godeps to v0.25.0 Mar 15, 2017
@dashpole dashpole mentioned this pull request Mar 15, 2017
Closed
@timstclair timstclair added this to the v1.5 milestone Mar 15, 2017
@timstclair timstclair requested a review from justinsb March 15, 2017 18:05
@timstclair
Copy link

@justinsb for AWS dependency changes

@dashpole dashpole mentioned this pull request Mar 16, 2017
Closed
@justinsb
Copy link
Member

Works for me for AWS changes. We do have a 1.5 test job now for AWS, though it only runs daily IIRC: https://k8s-testgrid.appspot.com/google-aws#kops-aws-1.5

@dashpole
Copy link
Contributor Author

Does anyone know who to ping to get this in? This has been ready to go for a week.

@timstclair timstclair assigned dchen1107 and unassigned jbeda Mar 21, 2017
@timstclair
Copy link

@dashpole anyone from the root owners file approvers can approve: https://github.com/kubernetes/kubernetes/blob/master/OWNERS

@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2017
@dchen1107
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dchen1107

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2017
@dchen1107 dchen1107 added cherrypick-candidate and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Mar 21, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Mar 21, 2017
@dchen1107
Copy link
Member

cc/ @mwielgus The release czar for 1.5.x

@andrewsykim
Copy link
Member

@mwielgus friendly ping :)

@mwielgus mwielgus added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Mar 22, 2017
@mwielgus mwielgus self-assigned this Mar 22, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 6aa1195 into kubernetes:release-1.5 Mar 22, 2017
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@Bregor
Copy link

Bregor commented Mar 22, 2017

Please make a release with this patch!

$ ps aux|grep Z|wc -l
668

:(

@andrewsykim
Copy link
Member

andrewsykim commented Mar 23, 2017 •
edited
Loading

@mwielgus ^ another friendly ping :)

@dashpole dashpole deleted the release-1.5 branch March 23, 2017 17:57
@mcluseau
Copy link
Contributor

@Bregor I think I broke your record ;-)

# ps aux | grep -c '[wc]'
-bash: fork: retry: No child processes
-bash: fork: retry: No child processes
126372

@mcluseau
Copy link
Contributor

v1.5.6 is out and contains the fix (https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG.md#v156)

@Bregor
Copy link

Bregor commented Mar 29, 2017

@MikaelCluseau heh, I'm not a zombie lord anymore :(
:D

@andrewsykim
Copy link
Member

My worker nodes are running 1.5.6 and I see still the bug mentioned #27194. @Bregor @MikaelCluseau seeing anything similar?

@andrewsykim
Copy link
Member

Oops I linked to the wrong issue above. I meant #39812

@mcluseau
Copy link
Contributor

I have metrics on localhost:10255/metrics on all my hosts. Heapster has an issue somewhere thought, but I suspect it's more linked to my rshared mount ("Internal Error: failed RootFsInfo: error trying to get filesystem Device for dir /var/lib/kubelet: err: could not find device with major: 0, minor: 35 in cached partitions map").

@mcluseau
Copy link
Contributor

mcluseau commented Apr 7, 2017 •
edited
Loading

@andrewsykim FYI what I see is (like) #38337 (not on btrfs but probably the same cause)

@opskumu opskumu mentioned this pull request Apr 14, 2017
Closed
This was referenced Sep 11, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb approved these changes

Assignees

@dchen1107 dchen1107

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.