add and clear err message about RemoveVolumeFromReportAsAttached() #42317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/S
|
@k8s-bot cvm gce e2e test this |
|
This change is |
|
keep-open |
|
@NickrenREN reviewing now - sorry for the latency |
pmorie
added
the
lgtm
|
Thanks for the patch, @NickrenREN |
|
@k8s-bot unit test this |
|
@k8s-bot kops aws e2e test this |
saad-ali
suggested changes
May 5, 2017
| rc.actualStateOfWorld.RemoveVolumeFromReportAsAttached(attachedVolume.VolumeName, attachedVolume.NodeName) | ||
| err = rc.actualStateOfWorld.RemoveVolumeFromReportAsAttached(attachedVolume.VolumeName, attachedVolume.NodeName) | ||
| if err != nil { | ||
| glog.Errorf("RemoveVolumeFromReportAsAttached failed while removing volume %q from node %q with: %v", |
There was a problem hiding this comment.
glog.V(5).Infof instead of glog.Errorf since the error is non-blocking. I want to prevent spamming logs so I'm cautious when adding new errors with high visibility to loops.
NickrenREN
force-pushed
the
attach-detach-error-info-print
branch
from
a0c72d6 to
0861688
Compare
k8s-github-robot
removed
the
lgtm
saad-ali
approved these changes
May 9, 2017
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: NickrenREN, saad-ali
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: