Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backup-volfile-servers to mount option. #42038

Merged
merged 1 commit into from
Apr 3, 2017
Merged

Add backup-volfile-servers to mount option. #42038

merged 1 commit into from
Apr 3, 2017

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Feb 24, 2017 •
edited
Loading

This feature ensures the backup servers in the trusted pool is contacted if there is a failure in the connected server.
Mount option becomes:
mount -t glusterfs -o log-level=ERROR,log-file=/var/lib/kubelet/plugins/kubernetes.io/glusterfs/glustermount/glusterpod-glusterfs.log,backup-volfile-servers=192.168.100.0:192.168.200.0:192.168.43.149 ..

Signed-off-by: Humble Chirammal hchiramm@redhat.com

@humblec
This feature ensures the backup servers in the trusted pool
43c0a68 
is contacted if there is a failure in the connected server.
Mount option becomes:
mount -t glusterfs -o log-level=ERROR,log-file=/var/lib/kubelet/plugins/kubernetes.io/glusterfs/glustermount/glusterpod-glusterfs.log,backup-volfile-servers=192.168.100.0:192.168.200.0:192.168.43.149 ..

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@k8s-ci-robot
Copy link
Contributor

Hi @humblec. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 24, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Feb 24, 2017
@humblec humblec changed the title This feature ensures the backup servers in the trusted pool Add backup-volfile-servers to mount option. Feb 24, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@humblec
Copy link
Contributor Author

humblec commented Feb 24, 2017

@rootfs @jsafrane PTAL . This should work smooth even if the new mount option API come to life as like any other existing mount options. This is the same change introduced by PR ##33287

@jsafrane jsafrane added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Feb 24, 2017
@deads2k deads2k assigned jsafrane and rootfs and unassigned deads2k Feb 24, 2017
@jsafrane
Copy link
Member

@k8s-bot ok to test

@jsafrane
Copy link
Member

/lgtm
@rootfs, please check and approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2017
@jsafrane
Copy link
Member

heh, my lgtm means also approval... interesting. So let it be merged.

@rootfs
Copy link
Contributor

rootfs commented Feb 27, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: humblec, jsafrane, rootfs

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@humblec
Copy link
Contributor Author

humblec commented Mar 1, 2017

@jsafrane @rootfs Thanks.. The unit integration failure looks spurious one.

@humblec
Copy link
Contributor Author

humblec commented Mar 1, 2017

@k8s-bot unit test this

@humblec
Copy link
Contributor Author

humblec commented Mar 23, 2017

@k8s-bot test this

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 23, 2017 •
edited
Loading

@humblec: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins GKE smoke e2e 43c0a68 link @k8s-bot cvm gke e2e test this
Jenkins GCI GKE smoke e2e 43c0a68 link @k8s-bot gci gke e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@humblec
Copy link
Contributor Author

humblec commented Apr 3, 2017

@k8s-bot gci gke e2e test this

@humblec
Copy link
Contributor Author

humblec commented Apr 3, 2017

@k8s-bot cvm gke e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 42038, 42083)

@k8s-github-robot k8s-github-robot merged commit 46343f3 into kubernetes:master Apr 3, 2017
@jsafrane jsafrane mentioned this pull request Jul 21, 2017
Merged
openshift-merge-robot added a commit to openshift/origin that referenced this pull request Jul 27, 2017
@openshift-merge-robot
Merge pull request #15396 from jsafrane/gluster-auto-unmount-3.6
a691774 
Automatic merge from submit-queue

Gluster timeout patches

There are several upstream patches that shorten gluster timeout when remote gluster servers are unavailable. User gets an error about failed mount in 2 minutes instead of 2 minutes * 2 * nr. of gluster endpoints.

kubernetes/kubernetes#42038
kubernetes/kubernetes#49127
kubernetes/kubernetes#48709
kubernetes/kubernetes#49475

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1473587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jsafrane jsafrane

@rootfs rootfs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@humblec @k8s-ci-robot @k8s-reviewable @jsafrane @rootfs @k8s-github-robot @deads2k