-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote CronJobs to batch/v1beta1 - just the API #41901
Conversation
@kubernetes/sig-api-machinery-pr-reviews ptal as well |
Moved this issue into the next milestone @soltysh. This PR did not get cc: @ethernetdan, @kubernetes/kubernetes-release-managers |
@calebamiles I did file an exception, I'm waiting for hearing back. |
It looks like the cronjob controller is tightly coupled with |
@soltysh would it be easier if we remove |
It seems mean to break users when the serialization and behavior is actually compatible. Perhaps a series of simple reproducers will help us push past the problems with help from @kubernetes/sig-cli-bugs |
There's a proposal that could in theory subsume cron jobs |
@davidopp will you be able to attend sig-apps today and we can have a discussion. |
@soltysh Sorry, didn't see this in time. We'll be discussing the proposal at the sig-scheduling meeting today at 2:30 PM PT https://zoom.us/j/966775765 |
@davidopp sorry but too late for me :( I'll watch the recording and will catch up with you later this week. |
@janetkuo ptal, I've enabled only the API here so that we can move with this forward. I need to address the remaining bits, such us how to deal with CronJobs when both v2alpha1 and v1beta1 is enabled. But I'd prefer to do it as a followup, for now I've turned off this new API and when all the pieces will be in I'll re-enable it permanently. |
Forgot to actually comment the v1beta1 in master.go. Fixed, should be good. |
9f026cc
to
6d0e522
Compare
One more try, I've rebased |
Fixed last bit, the |
/retest |
@soltysh: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erictune, smarterclayton, soltysh Associated issue: 41890 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
This PR promotes CronJobs to beta.
@erictune @kubernetes/sig-apps-api-reviews @kubernetes/api-approvers ptal
This builds on top of #41890 and needs #40932 as well