Added configurable etcd initial-cluster-state to kube-up script. #41320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added conigurable etcd initial-cluster-state to kube-up script. This allows creation of multi-master cluster from scratch.
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
do-not-merge
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
jszczepkowski
added
cherrypick-candidate
cherry-pick-approved
|
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: jszczepkowski, wojtek-t Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
@k8s-bot unit test this |
|
Automatic merge from submit-queue |
jszczepkowski
added a commit
to jszczepkowski/kubernetes
that referenced
this pull request
Feb 13, 2017
Added configurable etcd initial-cluster-state to kube-up script. This allows creation of multi-master cluster from scratch. This is a cherry-pick of kubernetes#41320 from 1.5 branch.
|
@jszczepkowski: The following test(s) failed:
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-github-robot
pushed a commit
that referenced
this pull request
Feb 15, 2017
Automatic merge from submit-queue Added configurable etcd initial-cluster-state to kube-up script. Added configurable etcd initial-cluster-state to kube-up script. This allows creation of multi-master cluster from scratch. This is a cherry-pick of #41320 from 1.5 branch. ```release-note Added configurable etcd initial-cluster-state to kube-up script. ```
ahakanbaba
pushed a commit
to ahakanbaba/kubernetes
that referenced
this pull request
Feb 17, 2017
Added configurable etcd initial-cluster-state to kube-up script. This allows creation of multi-master cluster from scratch. This is a cherry-pick of kubernetes#41320 from 1.5 branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added configurable etcd initial-cluster-state to kube-up script. This allows creation of multi-master cluster from scratch.
Which issue this PR fixes
Before this PR, initial-cluster-state was determined based on the number of peers in etcd cluster: for more than one peer, the state was existing. It was not possible to create a cluster with 3 masters from scratch with state new.
Release note: