Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom CA file to openstack cloud provider config #41309

Merged
merged 1 commit into from
Feb 26, 2017
Merged

Add custom CA file to openstack cloud provider config #41309

merged 1 commit into from
Feb 26, 2017

Conversation

kars7e
Copy link

@kars7e kars7e commented Feb 13, 2017

What this PR does / why we need it: Adds ability to specify custom CA bundle file to verify OpenStack endpoint against. Useful in tests and PoC deployments. Similar to what #35488 did for authentication.

Which issue this PR fixes: None

Special notes for your reviewer: Based on #35488 which added support for custom CA file for authentication.

Release note:

@k8s-ci-robot
Copy link
Contributor

Hi @kars7e. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 13, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Feb 13, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@kars7e
Copy link
Author

kars7e commented Feb 13, 2017

I signed it!

@kars7e
Copy link
Author

kars7e commented Feb 13, 2017

I signed it!
(Had to update my email address, let's check again)

@kars7e
Add custom CA file to openstack cloud provider config
e3c8a0c 
In cases where insecure OpenStack endpoint is to be used
(e.g., when testing), gophercloud will fail to connect
to such endpoints. This patch adds support for custom CA
file configuration option, which, when provided, will
make gophercloud validate OpenStack endpoint against
certificate(s) read from file specified in that option.
@kars7e kars7e force-pushed the add-cafile-openstack branch from 7831f52 to e3c8a0c Compare February 13, 2017 23:55
@thockin
Copy link
Member

thockin commented Feb 21, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 21, 2017
@thockin
Copy link
Member

thockin commented Feb 21, 2017

Still not CLA happy.

@anguslees are you still reviewing Openstack PRs :)

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 22, 2017 •
edited
Loading

@kars7e: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins GCI GKE smoke e2e e3c8a0c link @k8s-bot gci gke e2e test this
Jenkins GKE smoke e2e e3c8a0c link @k8s-bot cvm gke e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@anguslees
Copy link
Member

@thockin: I'm not working on openstack anymore, and keeping up with reviews + @k8s-bot breakages was previously a full time job - so no, I'm trying not to review openstack PRs :/
So far the entire Openstack community has been unable to pony up a replacement headcount and my current not-very-successful strategy is to review them when I can find the time :(

anguslees
anguslees approved these changes Feb 22, 2017
View reviewed changes
Copy link
Member

@anguslees anguslees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@thockin
Copy link
Member

thockin commented Feb 22, 2017 via email

@kars7e
Copy link
Author

kars7e commented Feb 22, 2017 

@k8s-bot cvm gce e2e test this

@anguslees
Copy link
Member

@k8s-bot cvm gce e2e test this
/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: anguslees, kars7e

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2017
@kars7e
Copy link
Author

kars7e commented Feb 23, 2017

@k8s-bot cvm gce e2e test this

@thockin thockin added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Feb 23, 2017
@thockin thockin added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Feb 23, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 40932, 41896, 41815, 41309, 41628)

@k8s-github-robot k8s-github-robot merged commit 9a218d4 into kubernetes:master Feb 26, 2017
dims pushed a commit to dims/kubernetes that referenced this pull request Feb 8, 2018
Merge pull request kubernetes#41309 from kars7e/add-cafile-openstack
d8b5437 
Automatic merge from submit-queue (batch tested with PRs 40932, 41896, 41815, 41309, 41628)

Add custom CA file to openstack cloud provider config

**What this PR does / why we need it**: Adds ability to specify custom CA bundle file to verify OpenStack endpoint against. Useful in tests and PoC deployments. Similar to what kubernetes#35488 did for authentication.  


**Which issue this PR fixes**: None

**Special notes for your reviewer**: Based on kubernetes#35488 which added support for custom CA file for authentication.

**Release note**:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguslees anguslees anguslees approved these changes

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kars7e @k8s-ci-robot @k8s-reviewable @thockin @anguslees @k8s-github-robot