Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user agent string to all client requests #4129

Merged
merged 2 commits into from
Feb 4, 2015
Merged

Add user agent string to all client requests #4129

merged 2 commits into from
Feb 4, 2015

Conversation

smarterclayton
Copy link
Contributor

Fixes #2596

@smarterclayton
Copy link
Contributor Author

Removed some unused code in kubectl while i was at it, and fixed hack local up cluster.

@nikhiljindal
Copy link
Contributor

Integration test failure seems relevant:
[utils.go:35] unable to connect to etcd for integration testing: 100: Key not found () [2]

@bgrant0607
Copy link
Member

Cool, thanks.

@smarterclayton
Copy link
Contributor Author

Should be cleaned up across all 3 scripts that use etcd::start

----- Original Message -----

Integration test failure seems relevant:
[utils.go:35] unable to connect to etcd for integration testing: 100: Key not
found () [2]

Reply to this email directly or view it on GitHub:
#4129 (comment)

@nikhiljindal
Copy link
Contributor

LGTM.
Can you please delete kubectl_test.go and I will merge.

@smarterclayton
Set a default user agent on all client.Client calls
0307d7b 
Form:
  kube-controller-manager/v0.10.0 (linux/amd64) kubernetes/550b98e

  <basename(os.Argv)>/<gitVersion> (<GOOS>/<GOARCH>) kubernetes/<shortGitCommit>

Can be set by other clients
@smarterclayton
Make hack/local-up-cluster.sh work again for etcd 2
449f9d9
@smarterclayton
Copy link
Contributor Author

Done.

----- Original Message -----

LGTM.
Can you please delete kubectl_test.go and I will merge.

Reply to this email directly or view it on GitHub:
#4129 (comment)

@nikhiljindal
Copy link
Contributor

Thanks!

nikhiljindal added a commit that referenced this pull request Feb 4, 2015
@nikhiljindal
Merge pull request #4129 from smarterclayton/add_user_agent
63c07ad 
Add user agent string to all client requests
@nikhiljindal nikhiljindal merged commit 63c07ad into kubernetes:master Feb 4, 2015
@smarterclayton smarterclayton deleted the add_user_agent branch February 11, 2015 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikhiljindal nikhiljindal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set User-Agent in client library
4 participants
@smarterclayton @nikhiljindal @bgrant0607 @brendandburns