Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeController sets NodeTaints instead of deleting Pods #41133

Merged
merged 3 commits into from
Feb 24, 2017
Merged

NodeController sets NodeTaints instead of deleting Pods #41133

merged 3 commits into from
Feb 24, 2017

Conversation

gmarek
Copy link
Contributor

@gmarek gmarek commented Feb 8, 2017 •
edited
Loading 

Add an alpha feature that makes NodeController set Taints instead of deleting Pods from not Ready Nodes.

cc @timothysc @wojtek-t @davidopp
@aveshagarwal - this PR just uses library functions from previous one.
@kevin-wangzefeng - the only thing that's left is to write an admission controller. I don't remember what was the agreements. Are you going to write it, or should I?

@gmarek gmarek added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 8, 2017
@gmarek gmarek self-assigned this Feb 8, 2017
@k8s-github-robot k8s-github-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Feb 8, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 8, 2017
@k8s-github-robot k8s-github-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 8, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@gmarek gmarek force-pushed the nc-taints branch 4 times, most recently from 5e70927 to 44bdb08 Compare February 8, 2017 15:57
@mikedanese
Copy link
Member

/approve

@deads2k
Copy link
Contributor

deads2k commented Feb 8, 2017

@derekwaynecarr @kubernetes/rh-cluster-infra

@gmarek gmarek added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Feb 9, 2017
@gmarek gmarek mentioned this pull request Feb 9, 2017
Merged
@davidopp davidopp mentioned this pull request Feb 9, 2017
Closed
12 tasks
@davidopp
Copy link
Member

Please don't merge without my LGTM

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2017
@davidopp davidopp mentioned this pull request Feb 12, 2017
Merged
@k8s-github-robot k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 13, 2017
@kevin-wangzefeng
Copy link
Member

@kevin-wangzefeng - the only thing that's left is to write an admission controller. I don't remember what was the agreements. Are you going to write it, or should I?

Yes, I'm going to write it.

@timothysc timothysc assigned davidopp and unassigned gmarek Feb 13, 2017
@timothysc timothysc self-requested a review February 13, 2017 21:41
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2017
@gmarek
Copy link
Contributor Author

gmarek commented Feb 23, 2017

@k8s-bot gci gke e2e test this

@gmarek
Copy link
Contributor Author

gmarek commented Feb 23, 2017

@davidopp I added another commit fixing problem introduced by @aveshagarwal PR.

Also @aveshagarwal - you were supposed to update the implementation of helper functions to just use fields instead of annotations, not delete them, because they're small. If you did my rebase would be no-op, because you didn't it wasn't. This is the reason why we had additional level of abstraction in first place. I want those few hours back.

@gmarek
Copy link
Contributor Author

gmarek commented Feb 23, 2017

@k8s-bot kops aws e2e test this

1 similar comment
@gmarek
Copy link
Contributor Author

gmarek commented Feb 23, 2017

@k8s-bot kops aws e2e test this

@gmarek
Copy link
Contributor Author

gmarek commented Feb 23, 2017

@davidopp PTAL

@davidopp
Copy link
Member

BTW I noticed this PR doesn't use the "standard" mechanism for enabling alpha features, e.g. see #30468. Maybe you can fix in a followup PR.

@davidopp
Copy link
Member

Sorry, that PR implemented the flag gate, doesn't demonstrate using it. But this PR does: #41617

@davidopp
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2017
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2017
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 24, 2017
@davidopp
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: davidopp, eparis, gmarek, k8s-merge-robot, liggitt, mikedanese

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 2bb9743 into kubernetes:master Feb 24, 2017
k8s-github-robot pushed a commit that referenced this pull request Feb 26, 2017
Merge pull request #41896 from kevin-wangzefeng/daemonset-infinite-de…
dd29e6c 
…fault-toleration-seconds

Automatic merge from submit-queue (batch tested with PRs 40932, 41896, 41815, 41309, 41628)

Make DaemonSets survive taint-based evictions when nodes turn unreachable/notReady

**What this PR does / why we need it**:
DaemonPods shouldn't be deleted by NodeController in case of Node problems.
This PR is to add infinite tolerations for Unreachable/NotReady NoExecute Taints, so that they won't be deleted by NodeController when a node goes unreachable/notReady.

**Which issue this PR fixes** :
fixes #41738 
Related PR: #41133


**Special notes for your reviewer**:

**Release note**:

```release-note
Make DaemonSets survive taint-based evictions when nodes turn unreachable/notReady.
```
k8s-github-robot pushed a commit that referenced this pull request Feb 26, 2017
Merge pull request #41815 from kevin-wangzefeng/enable-defaulttolerat…
77ba346 
…ionseconds-admission-controller

Automatic merge from submit-queue (batch tested with PRs 40932, 41896, 41815, 41309, 41628)

enable DefaultTolerationSeconds admission controller by default

**What this PR does / why we need it**:
Continuation of PR #41414, enable DefaultTolerationSeconds admission controller by default.


**Which issue this PR fixes**: 
fixes: #41860
related Issue: #1574, #25320
related PRs: #34825, #41133, #41414 

**Special notes for your reviewer**:

**Release note**:

```release-note
enable DefaultTolerationSeconds admission controller by default
```
@davidopp davidopp mentioned this pull request Feb 28, 2017
Closed
@wojtek-t wojtek-t mentioned this pull request Mar 15, 2017
Closed
@chenchun chenchun mentioned this pull request Jan 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidopp davidopp davidopp left review comments

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@davidopp davidopp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.