Add an example of how to attach labels to nodes and use nodeSelectors so... #4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue #2406 |
| @@ -0,0 +1,120 @@ | |||
| ## Node selection example | |||
There was a problem hiding this comment.
We'd also mention that pinging pod to specific machine using this approach is discouraged. This is a scheduling problem, not something user needs to take care of. The plan is to add more resource type for node, and more resource requirement for pod.
a-robinson
force-pushed
the
nodelabels
branch
from
d227e72 to
b06f7e9
Compare
|
Thanks for the review! I've fixed up everything you mentioned. |
|
LGTM, personally, I would soften the language around "discouraged" to be something like "generally this is unnecessary, as the scheduler will take care of it for you, but in certain circumstances like ..." |
a-robinson
force-pushed
the
nodelabels
branch
from
b06f7e9 to
8ba5a91
Compare
|
Sounds good, done. |
|
|
||
| ### Step One: Attach label to the node | ||
|
|
||
| Run `kubectl get nodes` to get the names of the nodes. Pick out the one that you want to add a label to. Note that label keys must be in the form of DNS labels (as described in the [identifiers doc](/docs/design/identifiers.md), meaning that they are not allowed to contain any upper-case letters. Then run `kubectl get node <node-name> -o yaml > node.yaml`. The contents of the file should look something like this: |
|
LGTM one minor comment |
… so that pods can be scheduled on specific nodes.
a-robinson
force-pushed
the
nodelabels
branch
from
8ba5a91 to
67b37aa
Compare
a-robinson
added a commit
that referenced
this pull request
Feb 4, 2015
Add an example of how to attach labels to nodes and use nodeSelectors so...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... that pods can be scheduled on specific nodes.