Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding vmdk file extension for vmDiskPath in vsphere DeleteVolume #40538

Merged
merged 1 commit into from
Jan 30, 2017
Merged

Adding vmdk file extension for vmDiskPath in vsphere DeleteVolume #40538

merged 1 commit into from
Jan 30, 2017

Conversation

divyenpatel
Copy link
Member

@divyenpatel divyenpatel commented Jan 26, 2017 •
edited
Loading

What this PR does / why we need it:
This fix is required to handle situation when volume path is not set with vmdk file extension.
DiskAttach call does not require vmdk file extension to be explicitly set in the file path, so in PV yaml file, users have option to set such file path.

Issue happens when such PV is created with persistentVolumeReclaimPolicy set to Delete, and user deletes associated PVC. Volume deletion will fail with the message: file was not found

Which issue this PR fixes *
Fixes: #40560

Special notes for your reviewer:
Tested fix with custom image: divyen/hyperkube-fix-deletevolume:latest (Image built using base v1.5.3-beta.0)
@kerneltime @BaluDontu please review this fix.

@k8s-ci-robot
Copy link
Contributor

Hi @divyenpatel. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 26, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jan 26, 2017
@kerneltime
Copy link

@k8s-bot ok to test

@kerneltime
Copy link

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: kerneltime

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2017
@BaluDontu
Copy link
Contributor

@divyenpatel :

  1. Can you rename the title to something which is meaningful for this PR.
  2. Also, create an issue for this PR in kubernetes/kubernetes repo. Don't refer it to issues created on forked sites.

@divyenpatel divyenpatel changed the title fix for vSphere DeleteVolume Adding vmdk file extension for vmDiskPath in vsphere DeleteVolume Jan 26, 2017
@kerneltime
Copy link

This needs cherry picking into 1.5 and 1.4 release branches.

@brendandburns
Copy link
Contributor

/lgtm

LGTM from the bulk LGTM tool

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jan 30, 2017
@brendandburns brendandburns added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jan 30, 2017
@kerneltime
Copy link

@brendandburns if I understand correctly, the submit queue seems stuck waiting for an e2e run that is not scheduled.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 5b88f0e into kubernetes:master Jan 30, 2017
This was referenced Jan 30, 2017
Merged
Merged
@saad-ali saad-ali added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Jan 31, 2017
@saad-ali saad-ali added this to the v1.5 milestone Jan 31, 2017
k8s-github-robot pushed a commit that referenced this pull request Jan 31, 2017
Merge pull request #40693 from vmware/automated-cherry-pick-of-#40538…
8bbf2a9 
…-kubernetes-release-1.5

Automatic merge from submit-queue

Automated cherry pick of #40538

Cherry pick of #40538 on release-1.5.

#40538: fix for vSphere DeleteVolume
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

jessfraz added a commit that referenced this pull request Feb 1, 2017
@jessfraz
Merge pull request #40694 from vmware/automated-cherry-pick-of-#40538…
c69582d 
…-kubernetes-release-1.4

Automated cherry pick of #40538
@divyenpatel divyenpatel deleted the fixvSphereDeleteVolume branch May 2, 2017 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerneltime kerneltime kerneltime approved these changes

Assignees

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

Add vmdk file extension for vmDiskPath in vsphere DeleteVolume
10 participants
@divyenpatel @k8s-ci-robot @k8s-reviewable @kerneltime @k8s-github-robot @BaluDontu @brendandburns @k8s-cherrypick-bot @jsafrane @saad-ali