Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add the ability to edit fields within a config map." #40421

Merged
merged 1 commit into from
Jan 25, 2017
Merged

Revert "Add the ability to edit fields within a config map." #40421

merged 1 commit into from
Jan 25, 2017
+1 −118

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jan 25, 2017 •
edited
Loading

Fixes #40396
This reverts commit 31eca37.

#38445 broke edit for all resources other than configmaps:

$ kubectl edit serviceaccount default
Error from server (NotFound): configmaps "serviceaccount" not found

also, edit is a generic command, we can't add subcommands that claim the configmap space and mess with the things resourcebuilder accepts

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 25, 2017
@liggitt liggitt mentioned this pull request Jan 25, 2017
Merged
@liggitt
Copy link
Member Author

liggitt commented Jan 25, 2017

cc @brendandburns @fabianofranz @kubernetes/sig-cli-pr-reviews

@k8s-github-robot k8s-github-robot added kind/old-docs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 25, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @bgrant0607
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@fabianofranz fabianofranz added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jan 25, 2017
@fabianofranz fabianofranz self-assigned this Jan 25, 2017
@fabianofranz
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2017
@fabianofranz
Copy link
Contributor

I'll investigate how the tests didn't catch that.

@liggitt liggitt added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2017
@liggitt
Copy link
Member Author

liggitt commented Jan 25, 2017 •
edited
Loading

LGTM by original reviewer, approving to get the revert in the queue before it needs rebase

@liggitt
Copy link
Member Author

liggitt commented Jan 25, 2017

cc @k8s-oncall once tests are green

@liggitt
Copy link
Member Author

liggitt commented Jan 25, 2017

I'll investigate how the tests didn't catch that.

looks like a known issue - #39168

@bgrant0607
Copy link
Member

bgrant0607 commented Jan 25, 2017 via email

@fabianofranz
Copy link
Contributor

Fixes #40396

@liggitt liggitt mentioned this pull request Jan 25, 2017
Merged
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 38905, 40421)

@k8s-github-robot k8s-github-robot merged commit 90b5d4c into kubernetes:master Jan 25, 2017
@liggitt liggitt mentioned this pull request Jan 25, 2017
Closed
@liggitt liggitt deleted the revert-configmapedit branch January 25, 2017 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabianofranz fabianofranz

@0xmichalis 0xmichalis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@liggitt @k8s-reviewable @k8s-github-robot @fabianofranz @bgrant0607 @0xmichalis @k8s-ci-robot