Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GCI/COS OS detection in e2e test #40230

Closed
wants to merge 1 commit into from
Closed

Update GCI/COS OS detection in e2e test #40230

wants to merge 1 commit into from

Conversation

adityakali
Copy link
Contributor

Newer Container-Optimized OS images can be identified by "ID=cos"
in the /etc/os-release.

cc @Amey-D @mtaufen PTAL

@adityakali
Update GCI/COS OS detection in test
2556a58 
Newer Container-Optimized OS images can be identified by "ID=cos"
in the /etc/os-release.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 20, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jan 20, 2017
@Amey-D
Copy link
Contributor

Amey-D commented Jan 20, 2017

LGTM

@timstclair
Copy link

Thanks. Is this the most robust way of doing this check?

@timstclair
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2017
@k8s-github-robot
Copy link

Adding do-not-merge because the release note process has not been followed.
One of the following labels is required "release-note", "release-note-action-required", "release-note-experimental" or "release-note-none".
Please see: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jan 20, 2017
@adityakali
Copy link
Contributor Author

Is this the most robust way of doing this check?
I think so. Checking the /etc/os-release should be pretty reliable.

Do you want to cherry-pick this in 1.5 branch as well?

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @Random-Liu
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@adityakali
Copy link
Contributor Author

@Random-Liu can you please review?
Also, please add release-note-none label (I don't have permission to add labels).
Thanks.

@adityakali adityakali mentioned this pull request Jan 24, 2017
Merged
@adityakali
Copy link
Contributor Author

This is obsolete after #40326. Do not merge.

@adityakali adityakali closed this Jan 24, 2017
@adityakali adityakali deleted the cos branch January 24, 2017 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@timstclair timstclair

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adityakali @k8s-reviewable @Amey-D @timstclair @k8s-github-robot @k8s-ci-robot