-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename experimental-cgroups-per-pod flag #39972
Rename experimental-cgroups-per-pod flag #39972
Conversation
@k8s-bot kops aws e2e test this |
@derekwaynecarr we need to define a roll out plan before this PR can be merged. I think we both will agree that merging this PR earlier is better, so let's start working on a roll out plan asap. |
nit: just noticed there're still some TODOs in #27204, we need to also define which ones are in the scope of this rollout. |
@@ -34,7 +34,7 @@ NET_PLUGIN=${NET_PLUGIN:-""} | |||
NET_PLUGIN_DIR=${NET_PLUGIN_DIR:-""} | |||
SERVICE_CLUSTER_IP_RANGE=${SERVICE_CLUSTER_IP_RANGE:-10.0.0.0/24} | |||
# if enabled, must set CGROUP_ROOT | |||
EXPERIMENTAL_CGROUPS_PER_QOS=${EXPERIMENTAL_CGROUPS_PER_QOS:-false} | |||
CGROUPS_PER_QOS=${CGROUPS_PER_QOS:-false} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be changed to true? or blank if we are changing the default in the code?
also this whole change causes --cgroup-root to be a required option yes? i.e. if i don't explicitly say --cgroups-per-qos=false, then --cgroup-root is required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have reduced this pr scope to just the new flag name but not enabling it.
the enable will be a follow-on pr next week.
4b5c5c0
to
75fa285
Compare
@vishh -- given the propensity for prs of this nature to cause rebase conflicts, i made this just the flag rename so we can have a much smaller pr next week to just change the default. |
@derekwaynecarr: The following test(s) failed:
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@@ -3,4 +3,4 @@ GCE_IMAGE_CONFIG_PATH=test/e2e_node/jenkins/image-config.yaml | |||
GCE_ZONE=us-central1-f | |||
GCE_PROJECT=k8s-jkns-ci-node-e2e | |||
CLEANUP=true | |||
KUBELET_ARGS='--experimental-cgroups-per-qos=true --cgroup-root=/' | |||
KUBELET_ARGS='--cgroups-per-qos=false --cgroup-root=/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it false here?
@@ -5,5 +5,5 @@ GCE_PROJECT=k8s-jkns-ci-node-e2e | |||
CLEANUP=true | |||
GINKGO_FLAGS='--skip="\[Flaky\]"' | |||
TEST_ARGS='--feature-gates=DynamicKubeletConfig=true' | |||
KUBELET_ARGS='--experimental-cgroups-per-qos=true --cgroup-root=/' | |||
KUBELET_ARGS='--cgroups-per-qos=false --cgroup-root=/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we disabling in this scenario?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why pod cgroups are disabled in two test suites. I'm ok with enabling them in a separate PR too, so this PR lgtm
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED The following people have approved this PR: derekwaynecarr, vishh Needs approval from an approver in each of these OWNERS Files:
We suggest the following people: |
Automatic merge from submit-queue (batch tested with PRs 40289, 40877, 40879, 39972, 40942) |
What this PR does / why we need it:
experimental-cgroups-per-qos
tocgroups-per-qos
CGROUP_DRIVER
with docker runtime if used.Special notes for your reviewer:
We plan to roll this feature out in the upcoming release. Previous node e2e runs were running with this feature on by default. We will default this feature on for all e2es next week.
Release note: