Ensure empty lists don't return nil items fields #39834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
|
@smarterclayton PTAL |
k8s-github-robot
added
size/M
liggitt
added
release-note
smarterclayton
approved these changes
Jan 13, 2017
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
This was referenced Jan 13, 2017
k8s-github-robot
pushed a commit
that referenced
this pull request
Jan 14, 2017
Automatic merge from submit-queue Only set empty list for list types If List() impls return non-list objects (like Status objects), we shouldn't try to set them to an empty list follow up to #39834
saad-ali
added
the
cherry-pick-approved
k8s-github-robot
pushed a commit
that referenced
this pull request
Jan 18, 2017
…#39886-upstream-release-1.5 Automatic merge from submit-queue Automated cherry pick of #39834 #39886 Cherry pick of #39834 #39886 on release-1.5. ```release-note Fixes API compatibility issue with empty lists incorrectly returning a null `items` field instead of an empty array. ``` #39834: Ensure empty lists don't return nil items fields #39886: Only set empty list for list types
|
Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39822