Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #39311 #39485

Merged
merged 1 commit into from
Jan 10, 2017
Merged

Automated cherry pick of #39311 #39485

merged 1 commit into from
Jan 10, 2017

Conversation

rkouj
Copy link
Contributor

@rkouj rkouj commented Jan 5, 2017

Cherry pick of #39311 on release-1.5.

#39311: Check if pathExists before performing Unmount

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 5, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jan 5, 2017
@k8s-github-robot
Copy link

The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks)

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Jan 5, 2017
@rkouj
Copy link
Contributor Author

rkouj commented Jan 5, 2017

@k8s-bot node e2e test this

@rkouj
Copy link
Contributor Author

rkouj commented Jan 5, 2017

@k8s-bot cri node e2e test this

@rkouj
Copy link
Contributor Author

rkouj commented Jan 6, 2017

@k8s-bot node e2e test this

@rkouj
Copy link
Contributor Author

rkouj commented Jan 6, 2017 •
edited
Loading

I wonder if it is failing because the parent PR doesn't have the appropriate labels ? (cherrypick-candidate, milestone, release-note)

@jingxu97 jingxu97 added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Jan 6, 2017
@jingxu97 jingxu97 added this to the v1.5 milestone Jan 6, 2017
@jingxu97 jingxu97 added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 6, 2017
@rkouj
Copy link
Contributor Author

rkouj commented Jan 6, 2017

@k8s-bot node e2e test this

@rkouj
Copy link
Contributor Author

rkouj commented Jan 6, 2017

@k8s-bot cri node e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit efd2eb7. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

Jenkins CRI GCE Node e2e failed for commit efd2eb7. Full PR test history.

The magic incantation to run this job again is @k8s-bot cri node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@saad-ali
Copy link
Member

saad-ali commented Jan 9, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2017
@saad-ali
Copy link
Member

Failing E2Es hit #39597 which is now fixed. Rerunning failing E2E

@saad-ali
Copy link
Member

@k8s-bot node e2e test this

@saad-ali
Copy link
Member

@k8s-bot cri node e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit efd2eb7. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkouj
Copy link
Contributor Author

rkouj commented Jan 10, 2017

@k8s-bot cvm gce e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit efd2eb7. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkouj
Copy link
Contributor Author

rkouj commented Jan 10, 2017

@k8s-bot gce etcd3 e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 7afa237 into kubernetes:release-1.5 Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@saad-ali saad-ali

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
6 participants
@rkouj @k8s-reviewable @k8s-github-robot @k8s-ci-robot @saad-ali @jingxu97