-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if pathExists before performing Unmount #39311
Check if pathExists before performing Unmount #39311
Conversation
Jenkins Bazel Build failed for commit 264530f60d0ae3a018563e37335aee601cd46e1f. Full PR test history. The magic incantation to run this job again is |
Jenkins GCE etcd3 e2e failed for commit 264530f60d0ae3a018563e37335aee601cd46e1f. Full PR test history. The magic incantation to run this job again is |
Jenkins GCI GCE e2e failed for commit 264530f60d0ae3a018563e37335aee601cd46e1f. Full PR test history. The magic incantation to run this job again is |
Jenkins GCI GKE smoke e2e failed for commit 264530f60d0ae3a018563e37335aee601cd46e1f. Full PR test history. The magic incantation to run this job again is |
Jenkins Kubemark GCE e2e failed for commit 264530f60d0ae3a018563e37335aee601cd46e1f. Full PR test history. The magic incantation to run this job again is |
Jenkins GCE e2e failed for commit 264530f60d0ae3a018563e37335aee601cd46e1f. Full PR test history. The magic incantation to run this job again is |
Jenkins CRI GCE Node e2e failed for commit 264530f60d0ae3a018563e37335aee601cd46e1f. Full PR test history. The magic incantation to run this job again is |
Jenkins GCE Node e2e failed for commit 264530f60d0ae3a018563e37335aee601cd46e1f. Full PR test history. The magic incantation to run this job again is |
Jenkins verification failed for commit 264530f60d0ae3a018563e37335aee601cd46e1f. Full PR test history. The magic incantation to run this job again is |
264530f
to
f76fa39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add the check to emptyDir itself
f76fa39
to
8cec46e
Compare
Ack |
Jenkins unit/integration failed for commit 8cec46e. Full PR test history. The magic incantation to run this job again is |
Jenkins GKE smoke e2e failed for commit 8cec46e. Full PR test history. The magic incantation to run this job again is |
@k8s-bot unit test this |
@k8s-bot cvm gke e2e test this |
@saad-ali PTAL |
/lgtm |
Can you make sure to cherry-pick this and #38547 to 1.5 and possibly 1.4 |
@k8s-bot aws e2e test this |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
Removing label |
Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
Automatic merge from submit-queue (batch tested with PRs 39768, 39463) Check if path exists before performing unmount This is part 3 of an effort to check if path exists before performing an unmount operation. [Part 1](#38547) and [part 2](#39311) involved auditing the different volume plugins and refactoring their `TearDownAt()s` to use the common util function/or create one if absent. The ideal way to do this change would involve refactoring of the `TearDownAt()s` of these plugins and make a common util function that checks path. (The plugins involved in this PR use someway of unmounting a bind mount and unmounting a global path, there is also refactoring needed to consolidate disk_manager of fc, rbd and iscsi). A non-goal part of this effort can also involve refactoring all the `SetupAt()s` In the interest of time and considering other higher priority issues that I am caught up with, I am unable to give the time the refactoring needs. Hence I've made the minimum change that would give the desired output. I am tracking the work pending in this issue: #39251 ```release-note NONE ```
Automatic merge from submit-queue (batch tested with PRs 39768, 39463) Check if path exists before performing unmount This is part 3 of an effort to check if path exists before performing an unmount operation. [Part 1](kubernetes/kubernetes#38547) and [part 2](kubernetes/kubernetes#39311) involved auditing the different volume plugins and refactoring their `TearDownAt()s` to use the common util function/or create one if absent. The ideal way to do this change would involve refactoring of the `TearDownAt()s` of these plugins and make a common util function that checks path. (The plugins involved in this PR use someway of unmounting a bind mount and unmounting a global path, there is also refactoring needed to consolidate disk_manager of fc, rbd and iscsi). A non-goal part of this effort can also involve refactoring all the `SetupAt()s` In the interest of time and considering other higher priority issues that I am caught up with, I am unable to give the time the refactoring needs. Hence I've made the minimum change that would give the desired output. I am tracking the work pending in this issue: kubernetes/kubernetes#39251 ```release-note NONE ```
Automatic merge from submit-queue (batch tested with PRs 39768, 39463) Check if path exists before performing unmount This is part 3 of an effort to check if path exists before performing an unmount operation. [Part 1](kubernetes/kubernetes#38547) and [part 2](kubernetes/kubernetes#39311) involved auditing the different volume plugins and refactoring their `TearDownAt()s` to use the common util function/or create one if absent. The ideal way to do this change would involve refactoring of the `TearDownAt()s` of these plugins and make a common util function that checks path. (The plugins involved in this PR use someway of unmounting a bind mount and unmounting a global path, there is also refactoring needed to consolidate disk_manager of fc, rbd and iscsi). A non-goal part of this effort can also involve refactoring all the `SetupAt()s` In the interest of time and considering other higher priority issues that I am caught up with, I am unable to give the time the refactoring needs. Hence I've made the minimum change that would give the desired output. I am tracking the work pending in this issue: kubernetes/kubernetes#39251 ```release-note NONE ```
Unmount operation should not fail if path does not exist
Part two of: #38547
Plugins status captured here: #39251
cc: @saad-ali