Make liveness e2e test more hermetic #3929
Merged
+64
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid importing the YAML files from the examples/ tree, instead just define the api.Pod structs in the Go source code. Tested by running the TestLivenessHttp and TestLivenessExec tests against a test cluster.
satnam6502
added
the
lgtm
|
At some point we should build and use a tagged liveness Docker image (e.g. kubernetes/liveness:1.0) but for now LGTM. |
|
Merging since Travis shows green. |
satnam6502
added a commit
that referenced
this pull request
Jan 29, 2015
Make liveness e2e test more hermetic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid importing the YAML files from the examples/ tree, instead just
define the api.Pod structs in the Go source code.
Tested by running the TestLivenessHttp and TestLivenessExec tests
against a test cluster.
@satnam6502