Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ipvs kube-proxy #38817

Closed
wants to merge 4 commits into from
Closed

Ipvs kube-proxy #38817

wants to merge 4 commits into from

Conversation

mqliang
Copy link
Contributor

@mqliang mqliang commented Dec 15, 2016

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 15, 2016
@mqliang mqliang mentioned this pull request Dec 15, 2016
Closed
@mqliang
Copy link
Contributor Author

mqliang commented Dec 15, 2016

@boynux @knobunc @smarterclayton @bprashanth @kubernetes/sig-network

@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 15, 2016
@mqliang mqliang changed the title Ipvs proxy Ipvs kube-proxy Dec 15, 2016
@luxas
Copy link
Member

luxas commented Dec 17, 2016

Is there a proposal linked to this feature?
What are the benefits for a ipvs proxier vs the iptables one?
Can you line up that as a kubernetes/features issue at least if this is a thing that is aimed to get merged?

@k8s-ci-robot
Copy link
Contributor

Jenkins Bazel Build failed for commit c07383f. Full PR test history.

The magic incantation to run this job again is @k8s-bot bazel test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit c07383f. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit c07383f. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit c07383f. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit c07383f. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit c07383f. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit c07383f. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit c07383f. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit c07383f. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@boynux boynux mentioned this pull request Dec 19, 2016
Closed
@boynux
Copy link

boynux commented Dec 19, 2016

@luxas @mqliang I created a feature request for this PR. Please review to see if I missed anything

@resouer resouer mentioned this pull request Dec 20, 2016
Closed
@mqliang
Copy link
Contributor Author

mqliang commented Dec 21, 2016

Ok, will write a proposal in couple of days.

@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 23, 2016
@leslie-wang
Copy link

leslie-wang commented Jan 4, 2017 •
edited
Loading

@thockin I guess we probably need different ipvs LB policies. People can enable what they want. Direct routing mode doesn't work with port mapping, definitely need other mechanisms to enable it.

@mqliang Seems like current pull doesn't set LB policies. IPVS by default uses direct routing mode. Is it what you want? Considering ipvs node may be at separate nodes other than worker nodes, have you ever consider to use rest instead of direct library call. Maybe you can refer https://github.com/kobolog/gorb.

NB: since there are different kube-proxy mode, shall we consider using different proxy mode for different services? for example, service A, B, C uses ha-proxy, service X, Y, Z uses ipvs, etc.

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @brendandburns
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 24, 2017
@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 25, 2017
@k8s-github-robot
Copy link

@mqliang PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2017
@wojtek-t wojtek-t removed their assignment Jan 31, 2017
@sureshvis
Copy link

@miaoyq any plan for this PR ? we would like to explore ipvs

@thockin
Copy link
Member

thockin commented Mar 1, 2017 via email

@matthiasr matthiasr mentioned this pull request Mar 17, 2017
Closed
@jgmize jgmize mentioned this pull request Mar 30, 2017
Closed
@ghost
Copy link

ghost commented Apr 6, 2017

We have a tested implementation of IPVS kubeproxy in #44063

@thockin
Copy link
Member

thockin commented Apr 25, 2017

@mqliang - OK to close this to fold with #44063? One Pr is better than 2...

@mqliang mqliang closed this Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thockin thockin

@matchstick matchstick

Labels
area/kube-proxy cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.