Use a constant for the pod infra container name #3878
Merged
+64
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an implementation detail that has leaked out of kubelet. Use a constant to prevent divergence, for now. Plan to get rid of it. @dchen1107
|
Rerunning travis. |
|
I am almost done to completely hide network container / pod infra container from the user / client. Stalled by integration test at this moment. Do you think we still need this one? |
|
yes, please On Wed, Jan 28, 2015 at 11:41 AM, Dawn Chen notifications@github.com
|
satnam6502
added
priority/backlog
|
LGTM. Rerunning travis. |
bgrant0607
added a commit
that referenced
this pull request
Jan 30, 2015
Use a constant for the pod infra container name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation detail that has leaked out of kubelet. Use a
constant to prevent divergence, for now. Plan to get rid of it.
Also changed places that were using that same name, but did not really need it to be the same.
@dchen1107