Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS conf for Go1.7 #38600

Merged
merged 1 commit into from
Jan 5, 2017
Merged

Add TLS conf for Go1.7 #38600

merged 1 commit into from
Jan 5, 2017

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Dec 12, 2016

fixes #33936 / #38596

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Dec 12, 2016
@jessfraz jessfraz added this to the v1.4 milestone Dec 15, 2016
@jessfraz jessfraz added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Dec 15, 2016
@jessfraz
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@jessfraz: you can't LGTM a PR unless you are assigned as a reviewer.

In response to this comment:

/lgtm

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@jessfraz jessfraz self-requested a review December 15, 2016 22:33
@jessfraz jessfraz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2016
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Dec 15, 2016
@k82cn
Copy link
Member Author

k82cn commented Dec 24, 2016

PR for master at #39213 . PTAL

@thockin thockin added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Dec 27, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 6fb98ac. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k82cn
Copy link
Member Author

k82cn commented Jan 2, 2017

@k8s-bot gce etcd3 e2e test this

@k82cn
Copy link
Member Author

k82cn commented Jan 2, 2017

@k8s-bot unit test this

@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 96 hours old. Re-running tests.

@thockin
Copy link
Member

thockin commented Jan 3, 2017

@k8s-bot verify test this

@thockin
Copy link
Member

thockin commented Jan 3, 2017

@k8s-bot gce etcd3 e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 6fb98ac. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 6fb98ac. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k82cn
Copy link
Member Author

k82cn commented Jan 3, 2017

@thockin , it seems we need to update Copyright from 2016 to 2017, any comments?

diff --git a/pkg/util/sets/string.go b/pkg/util/sets/string.go
index da66eaf8e7..baef7a6a2b 100644
--- a/pkg/util/sets/string.go
+++ b/pkg/util/sets/string.go
@@ -1,5 +1,5 @@
 /*
-Copyright 2016 The Kubernetes Authors.
+Copyright 2017 The Kubernetes Authors.

@thockin
Copy link
Member

thockin commented Jan 3, 2017

Rebase to upstream master - it's fixed there

@thockin
Copy link
Member

thockin commented Jan 3, 2017

oops, this is the release branch. Ugh, what a mess. @jessfraz - should we touch all the generated files to update dates (bogus_ or live with broken tests? :)

@jessfraz
Copy link
Contributor

jessfraz commented Jan 4, 2017

oh yeah I'll cherrypick the patch for the dates

@jessfraz
Copy link
Contributor

jessfraz commented Jan 4, 2017

ok i merged the pr to fix the dates

@jessfraz
Copy link
Contributor

jessfraz commented Jan 4, 2017

@k8s-bot verify test this please

@jessfraz
Copy link
Contributor

jessfraz commented Jan 4, 2017

@k8s-bot gce etcd3 e2e test this

@jessfraz
Copy link
Contributor

jessfraz commented Jan 5, 2017

all green merging

@jessfraz jessfraz merged commit 92417e7 into kubernetes:release-1.4 Jan 5, 2017
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@k82cn k82cn deleted the k8s_33936 branch May 16, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants