Add the ability to edit fields within a config map. #38445

brendandburns · 2016-12-09T06:25:07Z

Addresses part of #36222

Example command:

$ kubectl edit configmap foo --config-map-data=bar

Will open the data element named bar in the ConfigMap named foo in $EDITOR, the edited contents are then updated back to the config map.

@kubernetes/sig-cli

Add a special purpose tool for editing individual fields in a ConfigMap with kubectl

k8s-reviewable · 2016-12-09T06:25:15Z

This change is

fabianofranz · 2016-12-09T19:19:43Z

@brendandburns does edit configmap being a subcommand breaks the RESOURCE/NAME syntax (with slash)? Like in $ kubectl edit configmap/foo.

brendandburns · 2016-12-10T06:44:19Z

@fabianofranz it won't break it, but it will make this particular command not work...

Subcommand seemed cleaner than a type-specific hack in edit.go but I'm open to other ideas.

juanvallejo · 2016-12-12T16:04:36Z

@brendandburns would pkg/kubectl/cmd/edit_configmap.go benefit from having a RunEditConfigmap function? RunEdit could also be called from there, and the command's Run: func(... might instead look something like:

Run: func(cmd *cobra.Command, args []string) {
   cmdutil.CheckErr(RunEditConfigmap(args))
}

This might make this file a bit easier to read

brendandburns · 2016-12-18T04:31:12Z

@juanvallejo done.

@fabianofranz any chance for another look at this?

Thanks!
--brendan

k8s-ci-robot · 2016-12-18T04:35:39Z

Jenkins Kubemark GCE e2e failed for commit 7ce1cae17f80e55ca6322e4722234eadd4f45641. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

k8s-ci-robot · 2016-12-18T04:35:39Z

Jenkins GCE e2e failed for commit 7ce1cae17f80e55ca6322e4722234eadd4f45641. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

k8s-ci-robot · 2016-12-18T04:35:39Z

Jenkins GCI GCE e2e failed for commit 7ce1cae17f80e55ca6322e4722234eadd4f45641. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

k8s-ci-robot · 2016-12-18T04:35:39Z

Jenkins GCE etcd3 e2e failed for commit 7ce1cae17f80e55ca6322e4722234eadd4f45641. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

k8s-ci-robot · 2016-12-18T04:53:11Z

Jenkins verification failed for commit 7ce1cae17f80e55ca6322e4722234eadd4f45641. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

k8s-ci-robot · 2016-12-19T04:49:41Z

Jenkins GKE smoke e2e failed for commit 37c09377a0daa47774a1cf2589d6369f1c0cdf3b. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

brendandburns · 2016-12-19T17:51:17Z

@k8s-bot gci gke e2e test this.

brendandburns · 2016-12-19T17:51:25Z

@k8s-bot cvm gke e2e test this

brendandburns · 2016-12-19T17:51:33Z

@k8s-bot unit test this

brendandburns · 2016-12-19T21:12:51Z

@k8s-bot unit test this

k8s-ci-robot · 2016-12-20T04:31:38Z

Jenkins Bazel Build failed for commit b54f1b6c5a185b8a672071264b4bf7bddd650911. Full PR test history.

The magic incantation to run this job again is @k8s-bot bazel test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

fabianofranz · 2017-01-03T19:18:49Z

@k8s-bot unit test this

k8s-ci-robot · 2017-01-10T08:14:50Z

Jenkins unit/integration failed for commit bd2dd8ae75319aecd812948ea4b8a9dd7424c099. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

brendandburns · 2017-01-14T04:32:33Z

@k8s-bot gci gke e2e test this

brendandburns · 2017-01-15T04:58:42Z

@k8s-bot gci gke e2e test this

k8s-ci-robot · 2017-01-15T05:04:46Z

Jenkins GCI GKE smoke e2e failed for commit 0d264659230deb989235384fea1add884f9dd177. Full PR test history. cc @brendandburns

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

brendandburns · 2017-01-19T03:04:10Z

@fabianofranz I think this is ready to go...

Thanks!

fabianofranz · 2017-01-20T22:03:44Z

@brendandburns Mind adding a release note? I think this is worth one, tks!

brendandburns · 2017-01-21T04:23:02Z

@fabianofranz release note added.

Thanks

fabianofranz · 2017-01-23T14:00:12Z

Tks!

fabianofranz · 2017-01-23T14:00:17Z

/lgtm

k8s-github-robot · 2017-01-23T16:11:06Z

Automatic merge from submit-queue (batch tested with PRs 38445, 40292)

liggitt · 2017-01-25T14:13:55Z

pkg/kubectl/cmd/edit.go

@@ -100,12 +100,20 @@ func NewCmdEdit(f cmdutil.Factory, out, errOut io.Writer) *cobra.Command {
 		Long:    editLong,
 		Example: fmt.Sprintf(editExample),
 		Run: func(cmd *cobra.Command, args []string) {
+			args = append([]string{"configmap"}, args...)


this breaks edit for all other resources

$ kubectl edit serviceaccount default Error from server (NotFound): configmaps "serviceaccount" not found

liggitt · 2017-01-25T14:17:45Z

this broke edit for all resources other than configmaps, @fabianofranz can you investigate how this passed kubectl tests?

also, edit is a generic command, we can't add subcommands that claim the configmap space

reverting in #40421

Automatic merge from submit-queue (batch tested with PRs 38905, 40421) Revert "Add the ability to edit fields within a config map." Fixes #40396 This reverts commit 31eca37. #38445 broke edit for all resources other than configmaps: ``` $ kubectl edit serviceaccount default Error from server (NotFound): configmaps "serviceaccount" not found ``` also, `edit` is a generic command, we can't add subcommands that claim the `configmap` space and mess with the things resourcebuilder accepts

mengqiy · 2017-03-22T23:19:21Z

Since this PR has been reverted in #40421.
/release-note-none

k8s-ci-robot · 2017-03-22T23:19:22Z

@ymqytw: you can only set release notes if you are the author or an assignee.

In response to this comment:

Since this PR has been reverted in #40421.
/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mengqiy · 2017-03-22T23:19:49Z

/assign @ymqytw

mengqiy · 2017-03-22T23:20:00Z

/release-note-none

KIVagant · 2018-05-23T08:54:47Z

@brendandburns , any chance to get this feature back? It would be very useful.

juanvallejo · 2018-05-23T14:56:08Z

@KIVagant there is currently a proposal (needs a KEP opened) that discusses a few approaches for adding this feature back

jose-fmeyer · 2019-09-02T14:54:55Z

Any chance we can revisit this feature? It would be quite useful to have...

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 9, 2016

k8s-github-robot assigned fabianofranz Dec 9, 2016

k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Dec 9, 2016

brendandburns mentioned this pull request Dec 10, 2016

PROPOSAL: Subcommand for easier editing of configmap keys #37965

Closed

brendandburns force-pushed the configmap2 branch from 2e43614 to 7ce1cae Compare December 18, 2016 04:30

k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2016

brendandburns force-pushed the configmap2 branch from 7ce1cae to 37c0937 Compare December 19, 2016 04:34

k8s-github-robot added the kind/old-docs label Dec 19, 2016

brendandburns force-pushed the configmap2 branch from 37c0937 to b54f1b6 Compare December 20, 2016 04:30

brendandburns force-pushed the configmap2 branch from b54f1b6 to bd2dd8a Compare January 10, 2017 07:55

Add the ability to edit fields within a config map.

31eca37

brendandburns force-pushed the configmap2 branch from 0d26465 to 31eca37 Compare January 15, 2017 05:12

brendandburns added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jan 21, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2017

k8s-github-robot merged commit 1f1f369 into kubernetes:master Jan 23, 2017

liggitt reviewed Jan 25, 2017

View reviewed changes

This was referenced Jan 25, 2017

Revert "Add the ability to edit fields within a config map." #40421

Merged

kubectl tests pass even if a command failed #39168

Closed

k8s-ci-robot assigned mengqiy Mar 22, 2017

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 22, 2017

Add the ability to edit fields within a config map. #38445

Add the ability to edit fields within a config map. #38445

Conversation

brendandburns commented Dec 9, 2016 • edited Loading

k8s-reviewable commented Dec 9, 2016

fabianofranz commented Dec 9, 2016

brendandburns commented Dec 10, 2016

juanvallejo commented Dec 12, 2016

brendandburns commented Dec 18, 2016

k8s-ci-robot commented Dec 18, 2016

k8s-ci-robot commented Dec 18, 2016

k8s-ci-robot commented Dec 18, 2016

k8s-ci-robot commented Dec 18, 2016

k8s-ci-robot commented Dec 18, 2016

k8s-ci-robot commented Dec 19, 2016

brendandburns commented Dec 19, 2016

brendandburns commented Dec 19, 2016

brendandburns commented Dec 19, 2016

brendandburns commented Dec 19, 2016

k8s-ci-robot commented Dec 20, 2016

fabianofranz commented Jan 3, 2017

k8s-ci-robot commented Jan 10, 2017

brendandburns commented Jan 14, 2017

brendandburns commented Jan 15, 2017

k8s-ci-robot commented Jan 15, 2017

brendandburns commented Jan 19, 2017

fabianofranz commented Jan 20, 2017

brendandburns commented Jan 21, 2017

fabianofranz commented Jan 23, 2017

fabianofranz commented Jan 23, 2017

k8s-github-robot commented Jan 23, 2017

liggitt Jan 25, 2017

Choose a reason for hiding this comment

liggitt Jan 25, 2017

Choose a reason for hiding this comment

liggitt commented Jan 25, 2017

mengqiy commented Mar 22, 2017

k8s-ci-robot commented Mar 22, 2017

mengqiy commented Mar 22, 2017

mengqiy commented Mar 22, 2017

KIVagant commented May 23, 2018

juanvallejo commented May 23, 2018

jose-fmeyer commented Sep 2, 2019 • edited Loading

brendandburns commented Dec 9, 2016 •

edited

Loading

jose-fmeyer commented Sep 2, 2019 •

edited

Loading