Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed default scsi controller type in vSphere Cloud Provider #38426

Merged
merged 1 commit into from
Dec 20, 2016
Merged

Changed default scsi controller type in vSphere Cloud Provider #38426

merged 1 commit into from
Dec 20, 2016

Conversation

abrarshivani
Copy link
Contributor

@abrarshivani abrarshivani commented Dec 9, 2016 •
edited
Loading

This PR changes default scsi controller to pvscsi in vSphere Cloud Provider. Fixes #37527

@k8s-ci-robot
Copy link
Contributor

Hi @abrarshivani. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 9, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@abrarshivani
Copy link
Contributor Author

//cc @pdhamdhere @kerneltime @BaluDontu

@abrarshivani abrarshivani mentioned this pull request Dec 9, 2016
Closed
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Dec 9, 2016
pdhamdhere
pdhamdhere approved these changes Dec 9, 2016
View reviewed changes
Copy link

@pdhamdhere pdhamdhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kerneltime
Copy link

We will need to cherry-pick this to 1.4

@kerneltime kerneltime mentioned this pull request Dec 9, 2016
Merged
jessfraz added a commit that referenced this pull request Dec 9, 2016
@jessfraz
Merge pull request #38509 from vmware/automated-cherry-pick-of-#38426…
4791b17 
…-kubernetes-release-1.4

Automated cherry pick of #38426
@jessfraz jessfraz added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Dec 9, 2016
@kerneltime
Copy link

Fixes #37527

@kerneltime
Copy link

@k8s-bot ok to test

@abrarshivani
Copy link
Contributor Author

@kerneltime Can you please run @k8s-bot cvm gke e2e test this?

@k8s-ci-robot
Copy link
Contributor

@abrarshivani: you can't request testing unless you are a kubernetes member.

In response to this comment:

@kerneltime Can you please run @k8s-bot cvm gke e2e test this?

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@mikedanese mikedanese added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2016
@mikedanese
Copy link
Member

@k8s-bot cvm gke e2e test this

@mikedanese
Copy link
Member

@k8s-bot bazel test this

(seems to have not picked up)

@mikedanese
Copy link
Member

@k8s-bot cvm gke e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 9484212 into kubernetes:master Dec 20, 2016
@kerneltime kerneltime mentioned this pull request Jan 11, 2017
Merged
mikedanese added a commit that referenced this pull request Jan 19, 2017
@mikedanese
Merge pull request #39751 from vmware/automated-cherry-pick-of-#38426…
53c151e 
…-kubernetes-release-1.5

Automated cherry pick of #38426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdhamdhere pdhamdhere pdhamdhere approved these changes

@kerneltime kerneltime kerneltime approved these changes

Assignees

@kerneltime kerneltime

@mikedanese mikedanese

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@abrarshivani @k8s-ci-robot @k8s-reviewable @kerneltime @mikedanese @k8s-github-robot @pdhamdhere @jessfraz