Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubelet: Add image cache. #38375

Merged
merged 1 commit into from
Dec 9, 2016
Merged

Kubelet: Add image cache. #38375

merged 1 commit into from
Dec 9, 2016

Conversation

Random-Liu
Copy link
Member

@Random-Liu Random-Liu commented Dec 8, 2016 •
edited by yujuhong
Loading

Fixes #38373.

This should be patched into 1.5.1 to solve the customer issue.

@yujuhong
/cc @kubernetes/sig-node

@Random-Liu Random-Liu added area/kubelet release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Dec 8, 2016
@Random-Liu Random-Liu requested a review from yujuhong December 8, 2016 09:57
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 8, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 8, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit bde67b8. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@0xmichalis
Copy link
Contributor

Not sure how useful this can be for you guys but worth taking a look
@legionus @miminar @mfojtik @soltysh

@feiskyer
Copy link
Member

feiskyer commented Dec 8, 2016

Fixes 38373.

nit: link to the issue #38373.

Jenkins unit/integration test is failed, forgotten to update the related tests?

yujuhong
yujuhong reviewed Dec 8, 2016
View reviewed changes
Copy link
Contributor

@yujuhong yujuhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the unit tests needs fixing.

pkg/kubelet/images/image_gc_manager.go
@@ -142,16 +167,23 @@ func (im *realImageGCManager) Start() error {
}
}, 5*time.Minute, wait.NeverStop)

// Start a goroutine periodically updates image cache.
// TODO(random-liu): Merge this with the previous loop.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can easily merge the two loops. Not sure what this TODO is meant for.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detectImages also list image, in fact we can image list there. However, it doesn't list images as frequently as we need, so I add a TODO here to consider this later if needed. :)

@ncdc
Copy link
Member

ncdc commented Dec 8, 2016

cc @derekwaynecarr @smarterclayton for OpenShift backport consideration

@Random-Liu Random-Liu mentioned this pull request Dec 8, 2016
Merged
@Random-Liu
Copy link
Member Author

@yujuhong Fixed the unit test.

@yujuhong yujuhong added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 36419, 38330, 37718, 38244, 38375)

@k8s-github-robot k8s-github-robot merged commit bf1afd9 into kubernetes:master Dec 9, 2016
@Random-Liu Random-Liu deleted the add-image-cache branch December 9, 2016 01:14
@rmmh rmmh mentioned this pull request Dec 9, 2016
Closed
@smarterclayton
Copy link
Contributor

Yes to backport in Kube 1.4 and openshift I think. Status hangs are bad

@Random-Liu Random-Liu mentioned this pull request Dec 12, 2016
Merged
@jessfraz jessfraz added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 12, 2016
@dchen1107 dchen1107 mentioned this pull request Dec 13, 2016
Closed
@Random-Liu Random-Liu mentioned this pull request Dec 13, 2016
Merged
jessfraz added a commit that referenced this pull request Dec 13, 2016
@jessfraz
Merge pull request #38605 from Random-Liu/automated-cherry-pick-of-#3…
939cc0f 
…8375-upstream-release-1.4

Automated cherry pick of #38375
@saad-ali saad-ali added this to the v1.5 milestone Dec 14, 2016
@saad-ali saad-ali added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Dec 14, 2016
k8s-github-robot pushed a commit that referenced this pull request Dec 14, 2016
Merge pull request #38721 from Random-Liu/automated-cherry-pick-of-#3…
984fcc6 
…8375-upstream-release-1.5

Automatic merge from submit-queue

Automated cherry pick of #38375

Cherry pick of #38375 on release-1.5.

#38375: Add image cache.
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@hjacobs hjacobs mentioned this pull request Jan 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yujuhong yujuhong yujuhong left review comments

Assignees

@yujuhong yujuhong

Labels
area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.