Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mesos unit tests #38196

Merged
merged 1 commit into from
Dec 6, 2016
Merged

fix mesos unit tests #38196

merged 1 commit into from
Dec 6, 2016

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Dec 6, 2016

Fixes #37961

The name mesos3.internal.company.com is actually registered now. I'm betting some poor bastard is wondering why his internal infrastructure is getting crushed. :)

@sttts ptal

@deads2k deads2k added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 6, 2016
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 6, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@deads2k
Copy link
Contributor Author

deads2k commented Dec 6, 2016

@wojtek-t Who can manually merge this when its green?

@deads2k
Copy link
Contributor Author

deads2k commented Dec 6, 2016

@kubernetes/test-infra-maintainers This is blocking the queue.

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 6, 2016
@sttts
Copy link
Contributor

sttts commented Dec 6, 2016 •
edited
Loading

lgtm, until somebody adds a wildcard to example.org.

@deads2k
Copy link
Contributor Author

deads2k commented Dec 6, 2016

lgtm, until somebody adds a wildcard to example.org.

yeah, updated for .fail which is possible, but very unlikely.

@deads2k deads2k added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2016
@eparis eparis merged commit 81b3644 into kubernetes:master Dec 6, 2016
@saad-ali
Copy link
Member

saad-ali commented Dec 6, 2016

This needs to be cherry-picked to 1.5--unit tests suite for release-1.5 is failing: https://k8s-gubernator.appspot.com/builds/kubernetes-jenkins/logs/ci-kubernetes-test-go-release-1.5

@saad-ali saad-ali added this to the v1.5 milestone Dec 6, 2016
@saad-ali saad-ali mentioned this pull request Dec 6, 2016
Closed
@saad-ali saad-ali added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 6, 2016
@saad-ali saad-ali mentioned this pull request Dec 6, 2016
Merged
@sjenning sjenning mentioned this pull request Dec 6, 2016
Merged
saad-ali added a commit that referenced this pull request Dec 6, 2016
@saad-ali
Merge pull request #38202 from saad-ali/automated-cherry-pick-of-#37481-
df824f2 
#37675-#38074-#37870-#38196-upstream-release-1.5

Automated cherry pick of #37481 #37675 #38074 #37870 #38196 upstream release 1.5
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

This was referenced Dec 7, 2016
Closed
Merged
@rkouj rkouj mentioned this pull request Dec 7, 2016
Merged
@jessfraz jessfraz added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 7, 2016
jessfraz added a commit that referenced this pull request Dec 7, 2016
@jessfraz
Merge pull request #38311 from rkouj/automated-cherry-pick-of-#38196-…
e2d4136 
…upstream-release-1.4

Automated cherry pick of #38196
@ixdy ixdy mentioned this pull request Jan 11, 2017
Merged
@ixdy
Copy link
Member

ixdy commented Jan 11, 2017 •
edited
Loading

https://whois.icann.org/en/lookup?name=org.fail

here's hoping that @nasser doesn't feel like breaking these unit tests again :)

fabioy added a commit that referenced this pull request Jan 12, 2017
@fabioy
Merge pull request #39765 from ixdy/automated-cherry-pick-of-#39342-#…
6998c71 
…39074-upstream-release-1.3

Automated cherry pick of #39342 #39074 #38196
@nasser
Copy link

nasser commented Jan 21, 2017

no promises 😉

@deads2k deads2k deleted the fix-mesos branch February 1, 2017 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sttts sttts

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.