Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "@k8s-bot ok to test" on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands will still work. Regular contributors should join the org to skip this step.

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.

This change is 

I signed it

@elipapa can you try this:

source <(kubectl completion zsh | sed 's/_get_comp_words_by_ref "\$@"/_get_comp_words_by_ref "\$*"/')

@elipapa ^^ tested here with zsh 5.2. works fine.

I don't like the global s/\$\@/\$\{\*\}/. It does more than necessary, potentially introducing new regressions.

Which of the $@ breaks for you:

kubectl completion bash | grep '$@'
    _get_comp_words_by_ref "$@" cur prev words cword
    for w in "$@"; do
    for w in "$@"; do

Any news on this?

[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files:

• pkg/kubectl/OWNERS

We suggest the following people:
cc @sig-cli-maintainers
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@elipapa any updates?

I have retested the previous suggestion on a different system

source <(kubectl completion zsh | sed 's/_get_comp_words_by_ref "\$@"/_get_comp_words_by_ref "\$*"/')

and it does indeed work.

Lgtm. Please squash ASAP to get it into 1.6.

@sttts squashed. unsure on what i should do for the next step. any pointers?

@elipapa this PR will go into the submit queue now. So with some luck it's merged in an hour.

And thanks for the fix 👍

@sttts the fix was yours! i just found the problem

Automatic merge from submit-queue