Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows adding custom api scopes to service accounts available in minions. #381

Merged
merged 1 commit into from
Jul 9, 2014

Conversation

yugui
Copy link
Contributor

@yugui yugui commented Jul 9, 2014

No description provided.

@thockin
Copy link
Member

thockin commented Jul 9, 2014

Thanks for all the recent PRs and issues! Have you signed Google's CLA, as
described in https://github.com/thockin/kubernetes/blob/master/CONTRIB.md ?
I don't see your name on the list, but maybe I am missing it...

On Tue, Jul 8, 2014 at 11:05 PM, Yuki Yugui Sonoda <notifications@github.com

wrote:


You can merge this Pull Request by running

git pull https://github.com/yugui/kubernetes feature/api-scope

Or view, comment on, or merge it at:

#381
Commit Summary

  • Allows adding custom api scopes to service accounts available in

File Changes

Patch Links:

Reply to this email directly or view it on GitHub
#381.

@brendandburns
Copy link
Contributor

Yuki is a Googler (in Tokyo?) (in the future, you can tell since she's in the Google Cloud github org)

brendandburns added a commit that referenced this pull request Jul 9, 2014
Allows adding custom api scopes to service accounts available in minions.
@brendandburns brendandburns merged commit 4b6ff69 into kubernetes:master Jul 9, 2014
@thockin
Copy link
Member

thockin commented Jul 9, 2014

OH! My mistake. Thanks!

On Wed, Jul 9, 2014 at 11:19 AM, brendandburns notifications@github.com
wrote:

Merged #381 #381.

Reply to this email directly or view it on GitHub
#381 (comment)
.

vishh added a commit to vishh/kubernetes that referenced this pull request Apr 6, 2016
Simplify handling of progress bars and humanized values.
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
b3atlesfan pushed a commit to b3atlesfan/kubernetes that referenced this pull request Feb 5, 2021
When using hard coded subnet values in tests,
it's important that they don't accidently end
up being the same as acquired leases.
Use SubnetMin/SubnetMax in config to segrate
hard coded and dynamically allocatable ranges.

Fixes kubernetes#381
linxiulei pushed a commit to linxiulei/kubernetes that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants