Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in validation that was leftover from the previous way of externalizing services. #3807

Merged
merged 1 commit into from
Jan 27, 2015
Merged

Fix a bug in validation that was leftover from the previous way of externalizing services. #3807

merged 1 commit into from
Jan 27, 2015
+2 −17

Conversation

brendandburns
Copy link
Contributor

Closes #3804

@smarterclayton
Copy link
Contributor

LGTM, where did this logic go?

@thockin
Copy link
Member

thockin commented Jan 27, 2015

LGTM

@brendandburns
Copy link
Contributor Author

@smarterclayton we used to use Docker hostPort to expose external IPs, we're using service IP tables now, so it's much cleaner, and we can re-use ports.

brendandburns added a commit that referenced this pull request Jan 27, 2015
@brendandburns
Merge pull request #3807 from brendandburns/validation
95247b3 
Fix a bug in validation that was leftover from the previous way of externalizing services.
@brendandburns brendandburns merged commit 95247b3 into kubernetes:master Jan 27, 2015
@brendandburns brendandburns deleted the validation branch August 7, 2015 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Erroneous service port conflicts for external services
3 participants
@brendandburns @smarterclayton @thockin