Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set kernel.softlockup_panic =1 based on the flag. #38001

Merged
merged 1 commit into from
Dec 3, 2016

Conversation

dchen1107
Copy link
Member

ref: #37853

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 3, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@dchen1107
Copy link
Member Author

dchen1107 commented Dec 3, 2016

I created the cluster and checked the configs on the node:

# cat /proc/sys/kernel/softlockup_panic
1
# cat /proc/sys/kernel/softlockup_all_cpu_backtrace 
1

@dchen1107
Copy link
Member Author

cc/ @saad-ali

@saad-ali saad-ali added this to the v1.5 milestone Dec 3, 2016
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Dec 3, 2016
@@ -261,6 +261,20 @@ net.ipv4.ip_forward:
sysctl.present:
- value: 1

{% if pillar.get('softlockup_panic', '').lower() == 'true' %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Why add this to docker salt scripts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another place is kubelet salt scripts. It doesn't matter at kubelet or docker salt script, it just need to run on every CVM node.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this is a workaround to mitigate the issue until we build a new image.

@k8s-ci-robot
Copy link
Contributor

Jenkins kops AWS e2e failed for commit 38a63e3. Full PR test history.

The magic incantation to run this job again is @k8s-bot kops aws e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@roberthbailey
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2016
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Dec 3, 2016
@saad-ali saad-ali added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Dec 3, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 238ffdd into kubernetes:master Dec 3, 2016
@saad-ali saad-ali added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 6, 2016
saad-ali added a commit that referenced this pull request Dec 6, 2016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants