-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set kernel.softlockup_panic =1 based on the flag. #38001
Conversation
I created the cluster and checked the configs on the node:
|
cc/ @saad-ali |
@@ -261,6 +261,20 @@ net.ipv4.ip_forward: | |||
sysctl.present: | |||
- value: 1 | |||
|
|||
{% if pillar.get('softlockup_panic', '').lower() == 'true' %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Why add this to docker
salt scripts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another place is kubelet salt scripts. It doesn't matter at kubelet or docker salt script, it just need to run on every CVM node.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this is a workaround to mitigate the issue until we build a new image.
Jenkins kops AWS e2e failed for commit 38a63e3. Full PR test history. The magic incantation to run this job again is |
/lgtm |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
ref: #37853