I am good with this, and I see no reason to separate master and minion settings at this time.

Sent from my iPhone

On Jan 25, 2015, at 1:26 PM, Ryan Fowler notifications@github.com wrote:

I'd like to put something in my environment similar to NUM_MINIONS to control the amount of memory Vagrant VMs get. I'm happy to submit a pull request, but would like feedback on the environment variable names to expedite things.

Some options would be: KUBERNETES_MEMORY, KUBERNETES_RAM, KUBE_MEMORY, KUBE_RAM.

Or, Master and Minion could be split up, lending variable names such as KUBERNETES_MASTER_MEMORY, KUBERNETES_MINION_MEMORY. If we're doing that, it's probably safe to drop the KUBERNETES_ on the thought MASTER_MEMORY is specific enough to Kubernetes.

—
Reply to this email directly or view it on GitHub.

I added this locally to my Vagrantfile as:

Give VM 512MB of RAM by default

$vm_mem = (ENV['VM_MEM'] || 512).to_i

@derekwaynecarr you can commit this now!

but @ryfow would need to rebase first.

I rebased and changed default to 1024.

On Wed, Mar 4, 2015 at 2:23 PM, Eric Tune notifications@github.com wrote:

but @ryfow https://github.com/ryfow would need to rebase first.

—
Reply to this email directly or view it on GitHub
#3792 (comment)
.

LGTM