Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes shorthand flag -w from kubectl apply #37345

Merged
merged 1 commit into from
Nov 29, 2016
Merged

Removes shorthand flag -w from kubectl apply #37345

merged 1 commit into from
Nov 29, 2016

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented Nov 23, 2016 •
edited
Loading

Fixes #37342.

A shorthand flag -w was introduced as flag --prune-whitelist for kubectl apply two weeks ago. Turned out it is not what we should do. Removing this shorthand flag before 1.5 release to prevent further issues.

@ymqytw @pwittrock

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 23, 2016
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Nov 23, 2016
@mengqiy
Copy link
Member

mengqiy commented Nov 23, 2016

@k8s-bot gci gke e2e test this

@adohe-zz
Copy link

LGTM.

@MrHohn MrHohn changed the title Removes shorthand flag from kubectl apply Removes shorthand flag -w from kubectl apply Nov 23, 2016
@mengqiy
Copy link
Member

mengqiy commented Nov 28, 2016

cc: @kubernetes/kubectl

@smarterclayton smarterclayton added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2016
@smarterclayton smarterclayton added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Nov 28, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit f57c9c7. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit f57c9c7. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@pwittrock
Copy link
Member

Does this need to be merged in 1.5? If so we will need to cherrypick it.

@mengqiy
Copy link
Member

mengqiy commented Nov 28, 2016

Does this need to be merged in 1.5? If so we will need to cherrypick it.

@pwittrock Yes

@pwittrock pwittrock added this to the v1.5 milestone Nov 28, 2016
@pwittrock
Copy link
Member

@saad-ali fyi

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 93f6736 into kubernetes:master Nov 29, 2016
@saad-ali saad-ali mentioned this pull request Nov 30, 2016
Merged
saad-ali added a commit that referenced this pull request Nov 30, 2016
@saad-ali
Merge pull request #37670 from saad-ali/automated-cherry-pick-of-#37489-
96a69ce 
#37321-#37394-#37345-#37397-#37411-#37379-#37323-#37195-#37139-#37225-#37562-#37487-upstream-release-1.5

Automated cherry pick of #37489 #37321 #37394 #37345 #37397 #37411 #37379 #37323 #37195 #37139 #37225 #37562 #37487 upstream release 1.5
@saad-ali saad-ali added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed cherrypick-candidate labels Dec 1, 2016
@MrHohn MrHohn deleted the kubectl-apply-remove-w branch May 16, 2017 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarterclayton smarterclayton

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
10 participants
@MrHohn @mengqiy @adohe-zz @k8s-ci-robot @pwittrock @k8s-github-robot @smarterclayton @gmarek @brendandburns @saad-ali