Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick GCI mounter related PR to release 1.4 #37336

Merged
merged 1 commit into from
Dec 1, 2016
Merged

Cherrypick GCI mounter related PR to release 1.4 #37336

merged 1 commit into from
Dec 1, 2016

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented Nov 23, 2016 •
edited by jessfraz
Loading 

Add support for NFSv4 and GlusterFS in GCI base image

Background: GCI image does not contain necessary nfs or gluster
binaries. In order to handle nfs and gluster mount in GCI cluster, we
design a mounter system to enable mount via a pre-imaged container. This
mounter docker image has all the necessary binaries pre-installed. When
needed, mounter script will run rkt fly to start the container and run
mount command with mount propation set to shared. So the mount added
within the container will automatically be prpagated to the host.

This PR includes the following major commits:

  1. Add mounterPath flag to kubelet which can be passed to mount
    interface. When the flag is set, mount command will use the mounterPath
    passed in, otherwise, the defualt mount path specified in $PATH will be used.
  2. Add the code to setup the mounter script directory and enable the
    mounter on GCI node.
  3. Add the docker image and mounter script and set up the cluster
    configuration to install and use local file for rkt and mounter docker
    image.
  4. Update kubelet mount code to only invoke mounter script when mounting
    nfs or gluster type.
  5. Add node plubing and bhunding for GCI mounter in GCI e2e tests

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 23, 2016
@jingxu97 jingxu97 added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Nov 23, 2016
@jingxu97 jingxu97 added this to the v1.4 milestone Nov 23, 2016
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Nov 23, 2016
@jingxu97 jingxu97 force-pushed the Nov/mounter-release-1.4 branch from 95587fa to 9aa5d91 Compare November 23, 2016 02:52
@k8s-ci-robot
Copy link
Contributor

Jenkins Bazel Build failed for commit 9aa5d911937bb1ea8f78d6b2594934d0102f1627. Full PR test history.

The magic incantation to run this job again is @k8s-bot bazel test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@jingxu97 jingxu97 added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Nov 23, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit 9aa5d911937bb1ea8f78d6b2594934d0102f1627. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 9aa5d911937bb1ea8f78d6b2594934d0102f1627. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 9aa5d911937bb1ea8f78d6b2594934d0102f1627. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 9aa5d911937bb1ea8f78d6b2594934d0102f1627. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit 9aa5d911937bb1ea8f78d6b2594934d0102f1627. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 9aa5d911937bb1ea8f78d6b2594934d0102f1627. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 9aa5d911937bb1ea8f78d6b2594934d0102f1627. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@saad-ali
Copy link
Member

CC @rkouj

@jingxu97 jingxu97 force-pushed the Nov/mounter-release-1.4 branch from 9aa5d91 to c89de67 Compare November 23, 2016 06:53
@k8s-ci-robot
Copy link
Contributor

Jenkins CRI GCE Node e2e failed for commit c89de6785c717e46817a7ca6b2d6f3e2cace1e73. Full PR test history.

The magic incantation to run this job again is @k8s-bot cri node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@jessfraz jessfraz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Nov 23, 2016
@jessfraz
Copy link
Contributor

can you write a release note that sums all this up

@jingxu97
Copy link
Contributor Author

@k8s-bot kops aws e2e test this

@Random-Liu Random-Liu mentioned this pull request Nov 23, 2016
Merged
@jingxu97
Copy link
Contributor Author

@k8s-bot kops aws e2e test this

@jingxu97
Copy link
Contributor Author

@k8s-bot verify test this

@mtaufen
Copy link
Contributor

mtaufen commented Nov 24, 2016

@k8s-bot cri node e2e test this

@mtaufen mtaufen mentioned this pull request Nov 24, 2016
Closed
@jingxu97
Cherrypick GCI mounter related PR to release 1.4
14928d1 
This PR combines all changes for GCI mounter into one PR against release
1.4

Background: GCI image does not contain necessary nfs or gluster
binaries. In order to handle nfs and gluster mount in GCI cluster, we
design a mounter system to enable mount via a pre-imaged container. This
mounter docker image has all the necessary binaries pre-installed. When
needed, mounter script will run rkt fly to start the container and run
mount command with mount propation set to shared. So the mount added
within the container will automatically be prpagated to the host.

This PR includes the following major commits:
1. Add mounterPath flag to kubelet which can be passed to mount
interface. When the flag is set, mount command will use the mounterPath
passed in, otherwise, the defualt mount path specified in $PATH will be used.
2. Add the code to setup the mounter script directory and enable the
mounter on GCI node.
3. Add the docker image and mounter script and set up the cluster
configuration to install and use local file for rkt and mounter docker
image.
4. Update kubelet mount code to only invoke mounter script when mounting
nfs or gluster type.
5. Add node plubing and bhunding for GCI mounter in GCI e2e tests
@jingxu97 jingxu97 force-pushed the Nov/mounter-release-1.4 branch from c89de67 to 14928d1 Compare November 28, 2016 19:53
@jingxu97 jingxu97 mentioned this pull request Nov 28, 2016
Closed
@vishh
Copy link
Contributor

vishh commented Nov 29, 2016

@jessfraz I added a release note.
@jingxu97 Thanks for compiling this cherry-pick. LGTM.

@jingxu97 jingxu97 added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 29, 2016
@jingxu97
Copy link
Contributor Author

@k8s-bot test this issue: #IGNORE

@k8s-ci-robot
Copy link
Contributor

Jenkins kops AWS e2e failed for commit 14928d1. Full PR test history.

The magic incantation to run this job again is @k8s-bot kops aws e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

zmerlynn added a commit to zmerlynn/test-infra that referenced this pull request Nov 29, 2016
@zmerlynn
kops: Disable on release-1.4 as well
efb3cca 
c.f. kubernetes/kubernetes#37336

The deflaking and most of the e2e works weren't done until
release-1.5, and I'm not going to backport everything at this point.
@zmerlynn zmerlynn mentioned this pull request Nov 29, 2016
Merged
@zmerlynn
Copy link
Member

@k8s-bot kops aws e2e test this

@krzyzacy
Copy link
Member

it might worth fixing that golint error in 1.4 to knock off the verification test failure...

@vishh vishh mentioned this pull request Nov 30, 2016
Closed
@jessfraz
Copy link
Contributor

im going to fix the lint failure today then all these will be merged after, tracking is here: #37254

@jessfraz jessfraz added release-note Denotes a PR that will be considered when it comes time to generate release notes. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels Nov 30, 2016
@jessfraz
Copy link
Contributor

jessfraz commented Dec 1, 2016

@k8s-bot verify test this

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 14928d1. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@jingxu97
Copy link
Contributor Author

jingxu97 commented Dec 1, 2016

@k8s-bot verify test this

@jessfraz
Copy link
Contributor

jessfraz commented Dec 1, 2016

manually merging since the queue is blocked and all is green

@jessfraz jessfraz merged commit 644e56e into kubernetes:release-1.4 Dec 1, 2016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mtaufen mtaufen

@jessfraz jessfraz

@vishh vishh

@saad-ali saad-ali

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
10 participants
@jingxu97 @k8s-ci-robot @saad-ali @jessfraz @mtaufen @vishh @zmerlynn @krzyzacy @k8s-cherrypick-bot @k8s-github-robot