Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add log rotation to kubemark" #37217

Merged
merged 1 commit into from
Nov 21, 2016
Merged

Revert "Add log rotation to kubemark" #37217

merged 1 commit into from
Nov 21, 2016
+0 −27

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Nov 21, 2016 •
edited by k8s-oncall
Loading

Reverts #37095

Logrotate doesn't work in kubemark (and makes impossible to open files during the run on the kubemark master).

This change is Reviewable

@wojtek-t wojtek-t added release-note-none Denotes a PR that doesn't merit a release note. retest-not-required labels Nov 21, 2016
@wojtek-t wojtek-t added this to the v1.6 milestone Nov 21, 2016
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 21, 2016
@wojtek-t wojtek-t modified the milestones: v1.5, v1.6 Nov 21, 2016
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 21, 2016
@gmarek gmarek added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 9ccddb9. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@wojtek-t
Copy link
Member Author

I'm merging it manually to unblock kubemark failures debugging.

@wojtek-t wojtek-t merged commit 75108a3 into master Nov 21, 2016
@spxtr spxtr deleted the revert-37095-kubemark_logrotation branch December 1, 2016 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmarek gmarek

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
4 participants
@wojtek-t @k8s-ci-robot @gmarek @k8s-github-robot