revert revert of test/e2e/generated/BUILD #37114
Conversation
mikedanese
changed the title
|
This fixes bazel builds in the release branch. |
|
/lgtm @k8s-bot bazel build this |
k8s-ci-robot
added
the
lgtm
k8s-github-robot
added
size/S
|
Jenkins Bazel Build failed for commit ea192dd. Full PR test history. The magic incantation to run this job again is |
k8s-github-robot
added
size/M
mikedanese
added
release-note-none
|
@k8s-bot bazel build this |
| @@ -210,20 +210,13 @@ go_library( | |||
| ], | |||
| ) | |||
|
|
|||
| go_test( | |||
| # phony go_default_test. Bazel test run interprets these as | |||
There was a problem hiding this comment.
should these be go_binarys instead? our e2e infrastructure expects an e2e_test binary, I think.
There was a problem hiding this comment.
Hmm, good idea. I will see if that works
There was a problem hiding this comment.
I can't fix this without modifying rules_go. I will add it to the list of stuff to finish.
|
@k8s-bot bazel build this |
| go_test( | ||
| # this is a private library until we can support building the | ||
| # test binary | ||
| # TODO(mikedanese): fix @io_bazelbuild/rules_go |
There was a problem hiding this comment.
do you have an issue tracking this?
| deps = [ | ||
| "//pkg/api:go_default_library", | ||
| "//pkg/client/clientset_generated/internalclientset:go_default_library", | ||
| "//pkg/metrics:go_default_library", | ||
| "//test/e2e/framework:go_default_library", | ||
| "//vendor:github.com/onsi/ginkgo", | ||
| "//vendor:github.com/onsi/gomega", |
There was a problem hiding this comment.
why remove this? metrics_grabber_test.go still seems to directly depend on it.
There was a problem hiding this comment.
I was testing if gazel would still correctly manages this. It does. Fixed.
|
@k8s-bot bazel build this |
mikedanese
added
the
lgtm
|
Automatic merge from submit-queue |
broken in fad1990
This change is