Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure: support nics with multiple ipconfigs #36841

Merged
merged 1 commit into from
Nov 19, 2016
Merged

azure: support nics with multiple ipconfigs #36841

merged 1 commit into from
Nov 19, 2016
+6 −3

Conversation

colemickens
Copy link
Contributor

@colemickens colemickens commented Nov 15, 2016 •
edited by k8s-oncall
Loading

What this PR does / why we need it:

When I initially wrote the cloudprovider, the ipconfig primary field either wasn't present or wasn't populated. Now it is and we have someone trying to use kubelet on a node with a nic with multiple ipconfigs and they ran into this.

Which issue this PR fixes: n/a no issue filed.

Special notes for your reviewer:

Release note:

azure: support multiple ipconfigs on a NIC

If we can get this backported to 1.4.x, that would be great.

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Nov 15, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 6357c39. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 6357c39. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit 6357c39. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 6357c39. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 6357c39. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@colemickens
Copy link
Contributor Author

Looks like the CI infra is having some problems.

This change was validated as working by a colleague.

@brendandburns brendandburns added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Nov 17, 2016
@brendandburns
Copy link
Contributor

LGTM

@brendandburns
Copy link
Contributor

@k8s-bot test this please issue: IGNORE

(general CI problems)

@brendandburns brendandburns added this to the v1.5 milestone Nov 19, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 8588571 into kubernetes:master Nov 19, 2016
@chentao1596 chentao1596 mentioned this pull request Dec 5, 2016
Closed
@colemickens colemickens deleted the colemickens-pr-azure-multiple-ipconfig branch December 15, 2016 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brendandburns brendandburns

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@colemickens @k8s-ci-robot @brendandburns @k8s-github-robot @googlebot